superset icon indicating copy to clipboard operation
superset copied to clipboard

feat: allow configuring labels on init job

Open roeap opened this issue 2 years ago • 2 comments

SUMMARY

Allows to configure labels on init-job pods.

At my work we encourage use of Azure Workload identities. These require to set the azure.workload.identity/use: "true" label for the federated credential file to get mounted.

With these changes AAD enabled databases can be used requiring no additional credentials

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Haven't seen any means of testing the helm chart in the repo, but we deployed superset with the current changes, and it worked fine.

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

roeap avatar Oct 17 '23 19:10 roeap

Sorry I missed that ... docs are updated now.

roeap avatar Oct 25 '23 04:10 roeap

This one seems to have fallen off the map. Sorry about that. @roeap would you mind rebasing, and bumping the docs again? Hopefully we can finally get this through ;)

rusackas avatar Aug 22 '24 05:08 rusackas

So sorry about letting this one fall through the cracks 🙁 I'm closing this in favor of #25681 to get this improvement pushed through ASAP.

villebro avatar Nov 18 '24 17:11 villebro