superset icon indicating copy to clipboard operation
superset copied to clipboard

fix: issue #14985 — partition not working after 3rd level

Open RekhaZemoso opened this issue 2 years ago • 3 comments

SUMMARY

When we select partition chart it showing wrong information after 3rd level of partitions

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: Screenshot from 2023-03-21 15-36-44 Screenshot from 2023-03-21 15-37-16

After:: Screenshot from 2023-03-21 15-37-44 Screenshot from 2023-03-21 15-38-04

ADDITIONAL INFORMATION

  • [x] Has associated issue:https://github.com/apache/superset/issues/14985
  • [x] Changes UI

RekhaZemoso avatar Apr 14 '23 04:04 RekhaZemoso

Codecov Report

Merging #23688 (b6d6bb8) into master (a5c31b2) will increase coverage by 0.46%. The diff coverage is 66.30%.

:exclamation: Current head b6d6bb8 differs from pull request most recent head a90a598. Consider uploading reports for the commit a90a598 to get more accurate results

@@            Coverage Diff             @@
##           master   #23688      +/-   ##
==========================================
+ Coverage   67.62%   68.09%   +0.46%     
==========================================
  Files        1908     1922      +14     
  Lines       73682    74047     +365     
  Branches     7982     8101     +119     
==========================================
+ Hits        49828    50421     +593     
+ Misses      21806    21555     -251     
- Partials     2048     2071      +23     
Flag Coverage Δ
hive 53.17% <ø> (+0.43%) :arrow_up:
mysql 79.21% <ø> (?)
postgres 79.28% <ø> (+0.77%) :arrow_up:
presto 53.08% <ø> (+0.42%) :arrow_up:
python 83.14% <ø> (+0.82%) :arrow_up:
sqlite 77.79% <ø> (+0.77%) :arrow_up:
unit 53.01% <ø> (+0.49%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-ui-chart-controls/src/shared-controls/mixins.tsx 16.66% <ø> (ø)
...d/packages/superset-ui-chart-controls/src/types.ts 100.00% <ø> (ø)
.../packages/superset-ui-core/src/chart/types/Base.ts 100.00% <ø> (ø)
...s/superset-ui-core/src/components/SafeMarkdown.tsx 66.66% <ø> (ø)
...ackages/superset-ui-core/src/query/types/Filter.ts 100.00% <ø> (ø)
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
...plugins/legacy-plugin-chart-heatmap/src/Heatmap.js 0.00% <0.00%> (ø)
...gins/legacy-plugin-chart-world-map/src/WorldMap.js 0.00% <0.00%> (ø)
...plugins/legacy-plugin-chart-world-map/src/index.js 66.66% <ø> (ø)
...tend/plugins/legacy-preset-chart-nvd3/src/utils.js 15.92% <ø> (ø)
... and 189 more

... and 139 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Apr 14 '23 04:04 codecov[bot]

Thanks for the PR, and sorry it slid under the radar for so long. Can you give this PR a rebase, and we'll give it some review/testing if it passes CI?

rusackas avatar Feb 09 '24 20:02 rusackas

And thank you for the contribution @RekhaZemoso!

rusackas avatar Feb 09 '24 20:02 rusackas

@RekhaZemoso any intention to get this across the finish line? It doesn't look like it needs much :)

rusackas avatar Jun 03 '24 18:06 rusackas