superset icon indicating copy to clipboard operation
superset copied to clipboard

fix: Solve the problem of ineffective tooltip sorting

Open OlderBabyML opened this issue 2 years ago • 2 comments

SUMMARY

I failed to sort when I enabled tooltip sorting image I checked the code related to tooltip, and found that after finishing the tooltip sorting, the forecastValue will be recombined into an object of Record<string, ForecastValue>type, and the order of this object is uncertain, which is hashed by key, so the sorting is invalid image I tried to replace the Record type with an ordered array, and then the sorting succeeded image

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Create a new chart, add multiple dimensions to the chart, aggregate by multiple dimensions, and then open Tooltip sorting in the chart advanced settings

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [x] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

OlderBabyML avatar Mar 16 '23 10:03 OlderBabyML

@OlderBabyML would you be willing to give this a rebase to make it mergeable, and see if it passes CI? Then we can hopefully give this a test and review!

rusackas avatar Feb 09 '24 20:02 rusackas