superset icon indicating copy to clipboard operation
superset copied to clipboard

feat: Add ByteHouse database connector

Open RafsanMazumder opened this issue 2 years ago • 2 comments

SUMMARY

feat: Add ByteHouse database connector https://bytehouse.cloud/

TESTING INSTRUCTIONS

Manual Testing

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

RafsanMazumder avatar Feb 21 '23 21:02 RafsanMazumder

@villebro Thank you for your suggestion. I have added the conversion for _time_grain_expressions, as well as handled the Date & DateTime datatype.

RafsanMazumder avatar Mar 02 '23 01:03 RafsanMazumder

Looks like this one got away from us a bit! @rafsan-mazumder would you be willing to give this a rebase?

rusackas avatar Feb 09 '24 20:02 rusackas

Running CI 🤞

rusackas avatar Jun 06 '24 23:06 rusackas

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.67%. Comparing base (76d897e) to head (c3a300f). Report is 290 commits behind head on master.

Files Patch % Lines
superset/db_engine_specs/bytehouse.py 95.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #23140       +/-   ##
===========================================
+ Coverage   60.48%   83.67%   +23.19%     
===========================================
  Files        1931      519     -1412     
  Lines       76236    37512    -38724     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31390    -14724     
+ Misses      28017     6122    -21895     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.93% <70.00%> (-0.23%) :arrow_down:
javascript ?
mysql 77.20% <70.00%> (?)
postgres 77.31% <70.00%> (?)
presto 53.54% <70.00%> (-0.26%) :arrow_down:
python 83.67% <95.00%> (+20.19%) :arrow_up:
sqlite 76.76% <70.00%> (?)
unit 59.06% <95.00%> (+1.44%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 06 '24 23:06 codecov[bot]