superset icon indicating copy to clipboard operation
superset copied to clipboard

feat: Programmatically open "more filters" dropdown in Horizontal Filter Bar

Open geido opened this issue 2 years ago • 1 comments

SUMMARY

This PR adds the ability to open the "more filters" dropdown in the horizontal filter bar while refactoring the code to better differentiate between focus and hover actions on native filters.

AFTER

https://user-images.githubusercontent.com/60598000/204836413-190dc840-a2b3-4c1f-8385-86e31837947f.mp4

TESTING INSTRUCTIONS

  1. Enable HORIZONTAL_FILTER_BAR feature flag
  2. Open a dashboard
  3. Set the filter bar to horizontal
  4. Click on a filter that is currently within the "more filters" dropdown
  5. The dropdown should open and focus the filter

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [x] Required feature flags: HORIZONTAL_FILTER_BAR
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

geido avatar Nov 30 '22 15:11 geido

Codecov Report

Merging #22276 (0be3929) into master (2bdf22b) will increase coverage by 11.22%. The diff coverage is 43.47%.

@@             Coverage Diff             @@
##           master   #22276       +/-   ##
===========================================
+ Coverage   55.69%   66.92%   +11.22%     
===========================================
  Files        1846     1847        +1     
  Lines       70302    70602      +300     
  Branches     7689     7819      +130     
===========================================
+ Hits        39157    47247     +8090     
+ Misses      29151    21343     -7808     
- Partials     1994     2012       +18     
Flag Coverage Δ
hive 52.55% <ø> (ø)
javascript 53.92% <39.13%> (+0.13%) :arrow_up:
mysql 78.04% <ø> (?)
postgres 78.11% <ø> (?)
presto 52.45% <ø> (ø)
python 81.30% <ø> (+23.51%) :arrow_up:
sqlite 76.57% <ø> (?)
unit 50.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/superset-ui-core/src/query/types/Dashboard.ts 100.00% <ø> (ø)
...nd/src/dashboard/components/FiltersBadge/index.tsx 86.11% <0.00%> (ø)
...Filters/FilterBar/FilterControls/FilterControl.tsx 29.03% <ø> (ø)
...veFilters/FilterBar/FilterControls/FilterValue.tsx 5.71% <0.00%> (-0.61%) :arrow_down:
.../components/nativeFilters/FilterBar/Horizontal.tsx 100.00% <ø> (ø)
...rd/components/nativeFilters/FilterBar/Vertical.tsx 74.50% <ø> (ø)
...board/components/nativeFilters/FilterBar/index.tsx 50.00% <ø> (ø)
...ativeFilters/FilterBar/useFilterControlFactory.tsx 81.81% <ø> (ø)
...t-frontend/src/dashboard/reducers/nativeFilters.ts 40.74% <0.00%> (-3.26%) :arrow_down:
...filters/components/GroupBy/GroupByFilterPlugin.tsx 0.00% <ø> (ø)
... and 325 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Nov 30 '22 15:11 codecov[bot]

/testenv up FEATURE_HORIZONTAL_FILTER_BAR=true

kgabryje avatar Dec 01 '22 11:12 kgabryje

@kgabryje Container image not yet published for this PR. Please try again when build is complete.

github-actions[bot] avatar Dec 01 '22 11:12 github-actions[bot]

@kgabryje Ephemeral environment creation failed. Please check the Actions logs for details.

github-actions[bot] avatar Dec 01 '22 11:12 github-actions[bot]

@geido Can you rebase this? Docker fix is here

michael-s-molina avatar Dec 01 '22 17:12 michael-s-molina

Thanks for catching that @kgabryje! I am having a look

geido avatar Dec 01 '22 17:12 geido