superset
superset copied to clipboard
fix: Create dataset polish/bug fix
SUMMARY
This PR implements the following polishes:
- Pagination on the table should be 25 by default (previously set to 10)
- Align refresh buttons in the left panel
- Align width of selected tables in left panel with search input
- The width was only wrong when there was no scrollbar present. I implemented a function to detect if a scrollbar is present and apply padding only if there is no scrollbar
- Remove save button and
...
dropdown menu from the top right of the header- An
editing
prop was added in the header component so that it can be reused when building the edit dataset component
- An
- Brought the "Manage your databases here" blank state from SQL lab to the left panel
- Fixed a bug where the table wouldn't take the full height of the dataset panel when there is no "This table already has a dataset" banner at the top
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:

AFTER:

TESTING INSTRUCTIONS
- Go to
http://localhost:9000/dataset/add/?testing
- Select a database and a schema
- Select a schema with over 25 pages to see default for pagination
- Observe all the changes described above
ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
Codecov Report
Merging #22262 (985f6a9) into master (04b7a26) will increase coverage by
0.04%
. The diff coverage is76.66%
.
@@ Coverage Diff @@
## master #22262 +/- ##
==========================================
+ Coverage 66.86% 66.90% +0.04%
==========================================
Files 1846 1847 +1
Lines 70510 71241 +731
Branches 7723 8039 +316
==========================================
+ Hits 47144 47665 +521
- Misses 21364 21534 +170
- Partials 2002 2042 +40
Flag | Coverage Δ | |
---|---|---|
hive | 52.53% <ø> (ø) |
|
javascript | 54.04% <76.66%> (+0.25%) |
:arrow_up: |
mysql | ? |
|
postgres | 78.02% <ø> (ø) |
|
presto | 52.42% <ø> (ø) |
|
python | 81.20% <ø> (-0.05%) |
:arrow_down: |
sqlite | 76.49% <ø> (ø) |
|
unit | 50.92% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...d/src/SqlLab/components/SqlEditorLeftBar/index.tsx | 52.11% <ø> (+0.05%) |
:arrow_up: |
...iews/CRUD/data/dataset/AddDataset/Header/index.tsx | 57.14% <33.33%> (-24.68%) |
:arrow_down: |
...s/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx | 84.61% <50.00%> (-2.06%) |
:arrow_down: |
...erset-frontend/src/components/EmptyState/index.tsx | 77.55% <75.00%> (-0.23%) |
:arrow_down: |
...a/dataset/AddDataset/DatasetPanel/DatasetPanel.tsx | 90.19% <100.00%> (-1.48%) |
:arrow_down: |
...set-frontend/src/views/CRUD/data/dataset/styles.ts | 100.00% <100.00%> (ø) |
|
...d/src/views/CRUD/data/dataset/AddDataset/index.tsx | 51.61% <0.00%> (-8.39%) |
:arrow_down: |
superset-frontend/src/views/CRUD/data/hooks.ts | 57.69% <0.00%> (-5.95%) |
:arrow_down: |
superset/common/utils/dataframe_utils.py | 90.47% <0.00%> (-4.77%) |
:arrow_down: |
... and 44 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
/testenv up
@lyndsiWilliams Ephemeral environment spinning up at http://52.24.161.135:8080. Credentials are admin
/admin
. Please allow several minutes for bootstrapping and startup.
Ephemeral environment shutdown and build artifacts deleted.