superset icon indicating copy to clipboard operation
superset copied to clipboard

fix(dashboard): Fix filter card positioning for horizontal native filters

Open codyml opened this issue 2 years ago • 1 comments

SUMMARY

This PR is based on #22169 and fixes positioning of filter cards for horizontal and horizontal overflow native filters.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: Screen Shot 2022-11-23 at 3 24 20 PM Screen Shot 2022-11-23 at 3 24 25 PM

After: Screen Shot 2022-11-23 at 3 25 32 PM Screen Shot 2022-11-23 at 3 25 38 PM

TESTING INSTRUCTIONS

  • Confirm that horizontal and horizontal overflow filter cards don't overlap the items they're describing.

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [x] Required feature flags: HORIZONTAL_FILTER_BAR
  • [x] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

codyml avatar Nov 23 '22 22:11 codyml

Codecov Report

Merging #22212 (b960130) into master (64939f2) will not change coverage. The diff coverage is n/a.

:exclamation: Current head b960130 differs from pull request most recent head 50005b9. Consider uploading reports for the commit 50005b9 to get more accurate results

@@           Coverage Diff           @@
##           master   #22212   +/-   ##
=======================================
  Coverage   66.91%   66.91%           
=======================================
  Files        1839     1839           
  Lines       70079    70079           
  Branches     7636     7636           
=======================================
  Hits        46894    46894           
  Misses      21218    21218           
  Partials     1967     1967           
Flag Coverage Δ
javascript 53.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/dashboard/styles.ts 100.00% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Nov 23 '22 23:11 codecov[bot]