superset
superset copied to clipboard
fix: Display Error Messages in DB Connection Modal
SUMMARY
This PR is trying to dix issues where connection errors where showing up in the advanced tab as opposed to the basic tab in the sql alchemy uri connection modal.
Also, putting more information into the database connection modal.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://user-images.githubusercontent.com/48933336/204589465-fedb90be-c180-4a45-a4fa-f654d0472a76.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
Codecov Report
Merging #22200 (3a1eadf) into master (2bdf22b) will increase coverage by
11.15%
. The diff coverage is44.44%
.
@@ Coverage Diff @@
## master #22200 +/- ##
===========================================
+ Coverage 55.69% 66.85% +11.15%
===========================================
Files 1846 1847 +1
Lines 70302 70821 +519
Branches 7689 7917 +228
===========================================
+ Hits 39157 47347 +8190
+ Misses 29151 21448 -7703
- Partials 1994 2026 +32
Flag | Coverage Δ | |
---|---|---|
hive | 52.55% <ø> (ø) |
|
javascript | 53.87% <44.44%> (+0.07%) |
:arrow_up: |
mysql | 78.04% <ø> (?) |
|
postgres | 78.11% <ø> (?) |
|
presto | 52.45% <ø> (ø) |
|
python | 81.30% <ø> (+23.51%) |
:arrow_up: |
sqlite | 76.57% <ø> (?) |
|
unit | 50.86% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...c/views/CRUD/data/database/DatabaseModal/index.tsx | 41.78% <28.57%> (-0.21%) |
:arrow_down: |
...rontend/src/components/ErrorMessage/ErrorAlert.tsx | 92.85% <100.00%> (+2.61%) |
:arrow_up: |
...ilters/FilterBar/FilterControls/FilterControls.tsx | 69.76% <0.00%> (-0.45%) |
:arrow_down: |
...d/src/dashboard/components/gridComponents/Tabs.jsx | 80.53% <0.00%> (-0.09%) |
:arrow_down: |
...perset-frontend/src/views/RootContextProviders.tsx | 0.00% <0.00%> (ø) |
|
...et-frontend/src/filters/components/Select/types.ts | 100.00% <0.00%> (ø) |
|
...end/src/filters/components/Range/transformProps.ts | 100.00% <0.00%> (ø) |
|
...d/src/filters/components/GroupBy/transformProps.ts | 0.00% <0.00%> (ø) |
|
...src/filters/components/TimeGrain/transformProps.ts | 0.00% <0.00%> (ø) |
|
...rc/dashboard/util/useFilterFocusHighlightStyles.ts | 100.00% <0.00%> (ø) |
|
... and 312 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@eschutho have you seen this docker error before? It's preventing me from building an ephemeral.
/testenv up
@AAfghahi Ephemeral environment spinning up at http://35.161.176.24:8080. Credentials are admin
/admin
. Please allow several minutes for bootstrapping and startup.
/testenv up
@yousoph Ephemeral environment spinning up at http://54.187.4.90:8080. Credentials are admin
/admin
. Please allow several minutes for bootstrapping and startup.
/testenv up
@AAfghahi Ephemeral environment spinning up at http://18.236.95.123:8080. Credentials are admin
/admin
. Please allow several minutes for bootstrapping and startup.
Ephemeral environment shutdown and build artifacts deleted.