superset
superset copied to clipboard
fix(reports): force data generation in csv reports
SUMMARY
fixes: #22189
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
- create table chart
- setup csv report on that chart and enable
Ignore cache when generating screenshot - update data in datasource without bursting cache
- check csv in the report received, should contain new data
ADDITIONAL INFORMATION
- [x] Has associated issue: #22189
- [x] Required feature flags:
ALERTS_REPORTS - [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
Codecov Report
Merging #22196 (e8802b9) into master (6f2e76b) will decrease coverage by
0.04%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #22196 +/- ##
==========================================
- Coverage 66.89% 66.85% -0.05%
==========================================
Files 1805 1809 +4
Lines 69071 69119 +48
Branches 7369 7369
==========================================
Hits 46208 46208
- Misses 20956 21004 +48
Partials 1907 1907
| Flag | Coverage Δ | |
|---|---|---|
| hive | 52.57% <100.00%> (-0.35%) |
:arrow_down: |
| mysql | 78.08% <100.00%> (-0.17%) |
:arrow_down: |
| postgres | 78.15% <100.00%> (-0.17%) |
:arrow_down: |
| presto | 52.47% <100.00%> (-0.35%) |
:arrow_down: |
| python | 81.34% <100.00%> (-0.12%) |
:arrow_down: |
| sqlite | 76.60% <100.00%> (-0.20%) |
:arrow_down: |
| unit | 50.86% <0.00%> (-0.21%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| superset/charts/schemas.py | 99.35% <ø> (+<0.01%) |
:arrow_up: |
| superset/charts/data/api.py | 89.87% <100.00%> (+0.06%) |
:arrow_up: |
| superset/tables/schemas.py | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| superset/columns/schemas.py | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| superset/tables/models.py | 44.15% <0.00%> (-23.38%) |
:arrow_down: |
| superset/reports/notifications/slack.py | 79.51% <0.00%> (-8.49%) |
:arrow_down: |
| superset/databases/commands/create.py | 86.79% <0.00%> (-5.05%) |
:arrow_down: |
| superset/utils/urls.py | 97.22% <0.00%> (-2.78%) |
:arrow_down: |
| superset/databases/api.py | 93.53% <0.00%> (-1.99%) |
:arrow_down: |
| superset/explore/commands/get.py | 88.77% <0.00%> (-1.76%) |
:arrow_down: |
| ... and 77 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Should we also change Ignore cache when generating screenshot to Ignore cache when generating report as CSV, json do not need screenshots.
Thanks for the reviews 😀