feat: Uses new table component in Drill to Detail
SUMMARY
Uses the new table component in Drill to Detail to benefit from virtualization and deal with tables with many columns.
It also extends the new Table component with new cell and header renderers.
@eric-briscoe
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://user-images.githubusercontent.com/70410625/204310917-784885ee-51bd-4db9-a1e2-ad34b111f516.mov
https://user-images.githubusercontent.com/70410625/204310446-c28a3873-3231-4e21-8e57-d8a741755c2a.mov
TESTING INSTRUCTIONS
- Check that the pagination is working as intended
- Check that the columns are correctly formatted
- Check that you can select formatting for time columns
ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
@eric-briscoe I noticed an error in the browser console when paginating. It seems an internal table error. Can you check?
Codecov Report
Merging #22173 (19ce6ce) into master (eba7b3d) will increase coverage by
0.03%. The diff coverage is54.22%.
:exclamation: Current head 19ce6ce differs from pull request most recent head 87d4041. Consider uploading reports for the commit 87d4041 to get more accurate results
@@ Coverage Diff @@
## master #22173 +/- ##
==========================================
+ Coverage 66.86% 66.89% +0.03%
==========================================
Files 1840 1845 +5
Lines 70160 70281 +121
Branches 7657 7683 +26
==========================================
+ Hits 46909 47012 +103
+ Misses 21281 21277 -4
- Partials 1970 1992 +22
| Flag | Coverage Δ | |
|---|---|---|
| javascript | 53.79% <52.66%> (+0.10%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...ages/superset-ui-core/src/query/types/Dashboard.ts | 100.00% <ø> (ø) |
|
| ...superset-ui-core/src/query/types/PostProcessing.ts | 100.00% <ø> (ø) |
|
| ...packages/superset-ui-core/src/query/types/Query.ts | 100.00% <ø> (ø) |
|
| ...ins/plugin-chart-echarts/src/BoxPlot/buildQuery.ts | 66.66% <ø> (ø) |
|
| ...s/plugin-chart-echarts/src/BoxPlot/controlPanel.ts | 5.55% <ø> (ø) |
|
| ...ugins/plugin-chart-echarts/src/Radar/buildQuery.ts | 0.00% <0.00%> (ø) |
|
| ...charts/src/Timeseries/Regular/Bar/controlPanel.tsx | 35.71% <ø> (+4.46%) |
:arrow_up: |
| .../plugin-chart-echarts/src/Timeseries/buildQuery.ts | 71.42% <ø> (ø) |
|
| .../plugin-chart-pivot-table/src/plugin/buildQuery.ts | 42.85% <ø> (ø) |
|
| ...ugin-chart-pivot-table/src/plugin/controlPanel.tsx | 4.16% <0.00%> (ø) |
|
| ... and 48 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
/testenv up
@geido Ephemeral environment spinning up at http://35.92.48.144:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.
/testenv up FEATURE_DRILL_TO_DETAIL=true
@geido Ephemeral environment spinning up at http://52.41.165.144:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.
@geido @codyml I addressed your comments in the last commit.
https://user-images.githubusercontent.com/70410625/204849854-e9a7b678-c64a-4df3-a7d7-4b7f675f9365.mov
Ephemeral environment shutdown and build artifacts deleted.