superset
superset copied to clipboard
chore: Localization of several charts and elements
SUMMARY
The localization of some components and especially charts is not complete yet. This PR is the effort to achieve the full localization of Superset. Additionally, it is a real pain to upgrade Superset as one should solve tons of merge conflicts, if they wrapped everything in t()
and __()
manually, while it is not reflected in the official repo :/
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
@villebro take a look please
@michael-s-molina could you take a look please?
Codecov Report
Merging #22150 (4b7d0a6) into master (73e53fa) will decrease coverage by
11.25%
. The diff coverage is77.77%
.
:exclamation: Current head 4b7d0a6 differs from pull request most recent head 436723e. Consider uploading reports for the commit 436723e to get more accurate results
@@ Coverage Diff @@
## master #22150 +/- ##
===========================================
- Coverage 67.10% 55.84% -11.26%
===========================================
Files 1869 1869
Lines 71580 71582 +2
Branches 7806 7806
===========================================
- Hits 48031 39978 -8053
- Misses 21521 29576 +8055
Partials 2028 2028
Flag | Coverage Δ | |
---|---|---|
hive | ? |
|
mysql | ? |
|
postgres | ? |
|
presto | 52.50% <100.00%> (+<0.01%) |
:arrow_up: |
python | 57.88% <100.00%> (-23.44%) |
:arrow_down: |
sqlite | ? |
|
unit | 51.48% <83.33%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...-chart-controls/src/sections/advancedAnalytics.tsx | 14.28% <ø> (ø) |
|
...rt-controls/src/shared-controls/sharedControls.tsx | 55.17% <ø> (ø) |
|
...ui-core/src/chart/components/FallbackComponent.tsx | 100.00% <ø> (ø) |
|
...et-ui-core/src/chart/components/SuperChartCore.tsx | 100.00% <ø> (ø) |
|
...s/legacy-plugin-chart-calendar/src/controlPanel.ts | 50.00% <ø> (ø) |
|
...s/legacy-plugin-chart-heatmap/src/controlPanel.tsx | 57.14% <ø> (ø) |
|
...ns/legacy-plugin-chart-horizon/src/controlPanel.ts | 100.00% <ø> (ø) |
|
...ns/legacy-plugin-chart-map-box/src/controlPanel.ts | 30.00% <0.00%> (ø) |
|
...legacy-plugin-chart-partition/src/controlPanel.tsx | 25.00% <ø> (ø) |
|
...egacy-plugin-chart-pivot-table/src/controlPanel.ts | 100.00% <ø> (ø) |
|
... and 386 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
This generally looks good to me! I added a couple clarifying questions. In general, there seems like only one real pint of contention, which is that I'm not sure we want to include the colon-space combo in the translated strings, as the word(s) without the punctuation may provide utility in other settings. For example, name:
is translated, but we might just want to leverage name
which is probably already translated. I think this applies to several instances. Curious if others with experience in translations (e.g. @geido @ktmud @etr2460) might feel differently.
@rusackas According to this article it seems sometimes the punctuation could also be translated. Check the Punctuation section.
@rusackas According to this article it seems sometimes the punctuation could also be translated. Check the Punctuation section.
Makes sense... good enough for me. I'll give this my approval, but would love input on the other open questions, and more opinions on the matter before merging.
Approved CI to run. Fingers crossed!
Latest changes seem fine too.
I'll circle back to merge this if CI passes. If it doesn't, nag me here or on Slack, and we'll sort it out!