superset icon indicating copy to clipboard operation
superset copied to clipboard

feat(ssh_tunnel): Add SSH Tunnel feature flags

Open Antonio-RiveroMartnez opened this issue 2 years ago • 1 comments

SUMMARY

  • Add SSH Tunnel feature flags

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

Antonio-RiveroMartnez avatar Nov 16 '22 21:11 Antonio-RiveroMartnez

Codecov Report

Merging #22144 (5f913ef) into create-sshtunnelconfig-tbl (44ca56b) will decrease coverage by 1.49%. The diff coverage is 100.00%.

:exclamation: Current head 5f913ef differs from pull request most recent head dd6e4cd. Consider uploading reports for the commit dd6e4cd to get more accurate results

@@                      Coverage Diff                       @@
##           create-sshtunnelconfig-tbl   #22144      +/-   ##
==============================================================
- Coverage                       67.02%   65.52%   -1.50%     
==============================================================
  Files                            1838     1835       -3     
  Lines                           70077    70010      -67     
  Branches                         7571     7571              
==============================================================
- Hits                            46968    45876    -1092     
- Misses                          21150    22175    +1025     
  Partials                         1959     1959              
Flag Coverage Δ
hive ?
mysql 78.09% <100.00%> (+<0.01%) :arrow_up:
postgres 78.16% <100.00%> (+<0.01%) :arrow_up:
presto ?
python 78.28% <100.00%> (-3.10%) :arrow_down:
sqlite 76.62% <100.00%> (+<0.01%) :arrow_up:
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.87% <100.00%> (+0.02%) :arrow_up:
superset/databases/ssh_tunnel/dao.py 0.00% <0.00%> (-100.00%) :arrow_down:
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) :arrow_down:
...set/advanced_data_type/plugins/internet_address.py 16.32% <0.00%> (-79.60%) :arrow_down:
superset/utils/pandas_postprocessing/boxplot.py 20.51% <0.00%> (-79.49%) :arrow_down:
superset/charts/post_processing.py 11.76% <0.00%> (-77.95%) :arrow_down:
...perset/advanced_data_type/plugins/internet_port.py 18.75% <0.00%> (-77.09%) :arrow_down:
superset/utils/pandas_postprocessing/rolling.py 21.87% <0.00%> (-68.75%) :arrow_down:
...perset/utils/pandas_postprocessing/contribution.py 34.61% <0.00%> (-65.39%) :arrow_down:
superset/utils/pandas_postprocessing/resample.py 37.50% <0.00%> (-62.50%) :arrow_down:
... and 62 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Nov 17 '22 21:11 codecov[bot]