superset
superset copied to clipboard
fix(dashboard): chart doesn't resize when tab switch
SUMMARY
Currently the chart doesn't resize when tab switch.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
You can see the charts have been cut off:
https://user-images.githubusercontent.com/11830681/199552052-1f68738f-524c-4845-9022-79710d1b6619.mov
after
https://user-images.githubusercontent.com/11830681/199551845-041b294f-011e-4237-874d-99fd617ae7e5.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
- [ ] Has associated issue: https://github.com/apache/superset/issues/21852
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
Codecov Report
Merging #22009 (02f91f8) into master (bf00193) will decrease coverage by
0.00%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #22009 +/- ##
==========================================
- Coverage 66.95% 66.95% -0.01%
==========================================
Files 1807 1813 +6
Lines 69231 69427 +196
Branches 7406 7479 +73
==========================================
+ Hits 46357 46484 +127
- Misses 20966 21013 +47
- Partials 1908 1930 +22
Flag | Coverage Δ | |
---|---|---|
javascript | 53.46% <ø> (+0.06%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
.../src/dashboard/components/gridComponents/Chart.jsx | 53.98% <ø> (ø) |
|
superset-frontend/src/components/Select/styles.tsx | 81.81% <0.00%> (-18.19%) |
:arrow_down: |
...t-ui-chart-controls/src/shared-controls/mixins.tsx | 16.66% <0.00%> (-16.67%) |
:arrow_down: |
...perset-ui-chart-controls/src/sections/sections.tsx | 71.42% <0.00%> (-16.08%) |
:arrow_down: |
...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx | 62.73% <0.00%> (-6.29%) |
:arrow_down: |
superset-frontend/src/utils/downloadAsImage.ts | 11.11% <0.00%> (-4.68%) |
:arrow_down: |
...omponents/nativeFilters/FilterBar/Header/index.tsx | 95.45% <0.00%> (-4.55%) |
:arrow_down: |
...ontrols/DndColumnSelectControl/DndFilterSelect.tsx | 42.60% <0.00%> (-1.43%) |
:arrow_down: |
...et-frontend/src/components/TableSelector/index.tsx | 77.63% <0.00%> (-1.04%) |
:arrow_down: |
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx | 63.63% <0.00%> (-0.80%) |
:arrow_down: |
... and 39 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more