superset icon indicating copy to clipboard operation
superset copied to clipboard

feat: CSV File Upload form updates (Grouping with Collapse/Expand)

Open Antonio-RiveroMartnez opened this issue 2 years ago • 1 comments

SUMMARY

This is a follow up PR based on https://github.com/apache/superset/pull/21922 (So I'd suggest checking that one first so we can rebase this PR). Here we are grouping some input groups into collapsable sections, so our users can have a better experience while uploading CSV files. Since this level of customization escape from FAB default views, we are creating a new one and adding the correspondent templates with macros.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: error

After:

https://user-images.githubusercontent.com/38889534/199288362-5a0717ec-7a86-42e7-85cd-af2868afb40b.mov

test

TESTING INSTRUCTIONS

  1. Open the CSV file upload form
  2. Check the form matches the proposed changes

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [X] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [] Introduces new feature or API
  • [ ] Removes existing feature or API

Antonio-RiveroMartnez avatar Nov 01 '22 14:11 Antonio-RiveroMartnez

Codecov Report

Merging #21992 (76a1e52) into master (22fab5e) will decrease coverage by 0.74%. The diff coverage is 48.83%.

:exclamation: Current head 76a1e52 differs from pull request most recent head f266d22. Consider uploading reports for the commit f266d22 to get more accurate results

@@            Coverage Diff             @@
##           master   #21992      +/-   ##
==========================================
- Coverage   66.85%   66.10%   -0.75%     
==========================================
  Files        1841     1841              
  Lines       70197    70230      +33     
  Branches     7662     7664       +2     
==========================================
- Hits        46927    46426     -501     
- Misses      21296    21817     +521     
- Partials     1974     1987      +13     
Flag Coverage Δ
hive 52.54% <38.70%> (-0.02%) :arrow_down:
mysql ?
postgres ?
presto 52.44% <38.70%> (-0.02%) :arrow_down:
python 79.74% <41.93%> (-1.60%) :arrow_down:
sqlite 76.56% <41.93%> (-0.04%) :arrow_down:
unit 50.85% <35.48%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/dashboard/styles.ts 100.00% <ø> (ø)
...nts/controls/DateFilterControl/DateFilterLabel.tsx 58.13% <ø> (ø)
superset/connectors/sqla/models.py 88.72% <ø> (-0.60%) :arrow_down:
superset/models/helpers.py 38.19% <0.00%> (-0.09%) :arrow_down:
superset/views/database/views.py 31.27% <36.00%> (-0.09%) :arrow_down:
...nd/src/hooks/useTruncation/useCSSTextTruncation.ts 69.23% <55.55%> (-30.77%) :arrow_down:
...Filters/FilterBar/FilterControls/FilterDivider.tsx 81.48% <100.00%> (-18.52%) :arrow_down:
superset/connectors/base/models.py 87.20% <100.00%> (+0.07%) :arrow_up:
superset/views/database/forms.py 85.89% <100.00%> (+0.18%) :arrow_up:
superset/datasets/commands/create.py 30.61% <0.00%> (-69.39%) :arrow_down:
... and 38 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Nov 03 '22 22:11 codecov[bot]