superset icon indicating copy to clipboard operation
superset copied to clipboard

Upgrading from 2.0.0 to 2.0.1rc2 causes an error when setting owner and roles on dashboard

Open ziggekatten opened this issue 3 years ago • 4 comments

  1. Spin up an 2.0.0 Superset instalation in docker
  2. Create Dashboard.
  3. Edit setting on dashboard and you are able to set owner, and roles on dashboard
  4. Upgrade to 2.0.1rc2
  5. Edit setting on dashboard

Expected results

In owner and roles you should be able to select user / role

Actual results

An error appears in drop down: Cannot read properties of undefined (reading 'active'). This happens both in Owner and Role

Screenshots

image image

Environment

(please complete the following information):

  • browser type and version: Chrome 106.0.5249.119
  • superset version: 2.0.1
  • python version: 3.8.12
  • node.js version: node -v
  • any feature flags active: {"ALERT_REPORTS": True, "DASHBOARD_CROSS_FILTERS": True, "DASHBOARD_RBAC": True, "THUMBNAILS" : True, "THUMBNAILS_SQLA_LISTENERS": True, "ENABLE_TEMPLATE_PROCESSING": True, "ENABLE_TEMPLATE_REMOVE_ FILTERS": True, "ENABLE_SCHEDULED_EMAIL_REPORTS": True, "EMAIL_NOTIFICATIONS": True, "EMBEDDED_SUPERSET": True}

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • [X] I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • [X] I have reproduced the issue with at least the latest released version of superset.
  • [X] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

ziggekatten avatar Oct 31 '22 22:10 ziggekatten

We are also facing the same issue while adding owners to dashboards.

HetviTA avatar Oct 31 '22 23:10 HetviTA

Faced this error too. Found out that browser gets data for users and roles if you're clicking on the field. Also this happens only if you're editing dashboard properties. изображение_2022-11-17_103722784

shhhowtime avatar Nov 17 '22 03:11 shhhowtime

just for the record, I tried this migration some weeks ago .. and the entire application (frontend) wasn't work maybe it was something about custom html pages or maybe some configurations .. or something in the structure of package is different than the previous one .. and my own conda package (based on the conda-forge version) for that was not working properly

xmnlab avatar Nov 17 '22 13:11 xmnlab

also have the same issue

oleg-savko avatar Nov 26 '22 20:11 oleg-savko

Is this still an issue with the newer 2.0.1 release candidates? rc4 is up for testing, and rc5 is en route.

rusackas avatar Dec 09 '22 00:12 rusackas

yes still open. on my instance I get this error message in the newest rc5 image

mattrei avatar Dec 10 '22 09:12 mattrei

CC @eschutho @AAfghahi

rusackas avatar Dec 12 '22 20:12 rusackas

I think @eric-briscoe is hot on the trail of this one.

rusackas avatar Dec 15 '22 04:12 rusackas

This should be fixed for 2.0.1. Closing the issue, but feel to reopen if you find it again while testing.

eschutho avatar Dec 15 '22 18:12 eschutho

The error is gone now with 2.0.1-rc6 but we are still unable to change the dashboard ownership. If we try to save the changes nothing happens. I've checked the backend logs and looks like we are getting a 400 error on the API call to update the dashboard:

[16/Dec/2022:11:07:08 +0000] "PUT /api/v1/dashboard/6 HTTP/1.1" 400 75 "https://<ENDPOINT_REDACTED>/dashboard/list/?pageIndex=0&sortColumn=changed_on_delta_humanized&sortOrder=desc&viewMode=table" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36"

DiogoReisPinto avatar Dec 16 '22 11:12 DiogoReisPinto

2.0.1rc6 seems to fix this. Saving owner and roles does work in my test environment.

ziggekatten avatar Dec 17 '22 09:12 ziggekatten

Unfortunatelly, after upgrade superset to 2.0.1, it still cant update owners for dashboard:(

Screenshot 2022-12-26 at 12 57 56

oleg-savko avatar Dec 26 '22 09:12 oleg-savko

@eschutho can you reopen issue?

oleg-savko avatar Jan 06 '23 14:01 oleg-savko

Yeah, we'll take another look. Thanks for reporting. cc @eric-briscoe

eschutho avatar Jan 06 '23 23:01 eschutho

FYI I can't replicate this bug in 2.0.1, I can add/remove owners and roles on both existing (from 2.0.0) and new dashboards.

sfirke avatar Jan 11 '23 17:01 sfirke

@eschutho @eric-briscoe is this issue fully resolved. Is it safe to upgrade to 2.0.1 with dashboard_rbac enabled?

mdeshmu avatar Mar 01 '23 18:03 mdeshmu

@mdeshmu Does this issue only happen when you have dashboard_rbac enabled?

eschutho avatar Mar 16 '23 17:03 eschutho

Yes, this issue is specific to dashboard_rbac feature flag.

mdeshmu avatar Mar 16 '23 17:03 mdeshmu

This version of Superset is no longer supported. If anyone is still encountering this in current versions (3.x) please open a new Issue or a PR to address the problem.

rusackas avatar Feb 23 '24 18:02 rusackas