superset icon indicating copy to clipboard operation
superset copied to clipboard

fix(trino): Fix Trino timestamp conversion

Open mdesmet opened this issue 2 years ago • 5 comments

SUMMARY

Remove timestamp precision for custom python dttm conversion.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [x] Has associated issue: #16223, #21567
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

mdesmet avatar Oct 07 '22 14:10 mdesmet

@john-bodley could you please take a look and approve CI?

hovaesco avatar Oct 10 '22 09:10 hovaesco

I have tested this change and it addresses the timestamp filtering issue.

georgewfisher avatar Oct 12 '22 20:10 georgewfisher

thanks for the fix, approving CI.

mayurnewase avatar Oct 14 '22 00:10 mayurnewase

Codecov Report

Merging #21737 (08f2c9b) into master (60a617e) will increase coverage by 1.29%. The diff coverage is n/a.

:exclamation: Current head 08f2c9b differs from pull request most recent head cef7a1e. Consider uploading reports for the commit cef7a1e to get more accurate results

@@            Coverage Diff             @@
##           master   #21737      +/-   ##
==========================================
+ Coverage   65.56%   66.86%   +1.29%     
==========================================
  Files        1847     1847              
  Lines       70558    70558              
  Branches     7735     7735              
==========================================
+ Hits        46264    47181     +917     
+ Misses      22294    21377     -917     
  Partials     2000     2000              
Flag Coverage Δ
hive 52.53% <ø> (ø)
javascript 53.83% <ø> (ø)
mysql 77.95% <ø> (ø)
postgres 78.02% <ø> (ø)
presto 52.42% <ø> (ø)
python 81.23% <ø> (+2.73%) :arrow_up:
sqlite 76.48% <ø> (ø)
unit 50.91% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/views/CRUD/dashboard/DashboardList.tsx 56.60% <ø> (ø)
superset/databases/api.py 93.53% <0.00%> (+0.30%) :arrow_up:
superset/sql_lab.py 82.12% <0.00%> (+0.38%) :arrow_up:
superset/views/base_api.py 98.44% <0.00%> (+0.38%) :arrow_up:
superset/db_engine_specs/presto.py 88.22% <0.00%> (+0.41%) :arrow_up:
superset/db_engine_specs/__init__.py 85.71% <0.00%> (+1.19%) :arrow_up:
superset/datasets/schemas.py 97.40% <0.00%> (+1.29%) :arrow_up:
superset/commands/exceptions.py 93.84% <0.00%> (+1.53%) :arrow_up:
superset/initialization/__init__.py 90.96% <0.00%> (+2.00%) :arrow_up:
superset/utils/log.py 93.91% <0.00%> (+2.02%) :arrow_up:
... and 54 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Oct 14 '22 01:10 codecov[bot]

@mayurnewase who needs to review this PR in order for it to be committed?

georgewfisher avatar Nov 29 '22 22:11 georgewfisher

@mdesmet Thank you so much for this PR! Can update the description and use Fix before the ticket link in order to auto close these two tickets after PR merging

EugeneTorap avatar Dec 08 '22 08:12 EugeneTorap