superset icon indicating copy to clipboard operation
superset copied to clipboard

fix: Reset dataset name after saving a new dataset in SQL Lab

Open EugeneTorap opened this issue 3 years ago • 1 comments

SUMMARY

Fix #21271 issue when we create a dataset and provide some name and then want to do it again with the same name. In second dataset creation we got Untitled Query 7 08/31/2022 17:58:02 name but input has qwe1 name

BEFORE SCREENSHOTS OR ANIMATED GIF

https://user-images.githubusercontent.com/29536522/191249384-0f661b49-f744-49b3-8449-5f55e9181f68.mov

AFTER SCREENSHOTS OR ANIMATED GIF

https://user-images.githubusercontent.com/29536522/191249892-583862d2-f641-44c8-8b9a-88b690643a86.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

EugeneTorap avatar Sep 20 '22 11:09 EugeneTorap

Codecov Report

Merging #21529 (c90287c) into master (94a724e) will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #21529      +/-   ##
==========================================
- Coverage   66.67%   66.66%   -0.01%     
==========================================
  Files        1793     1793              
  Lines       68493    68500       +7     
  Branches     7275     7279       +4     
==========================================
  Hits        45665    45665              
- Misses      20966    20971       +5     
- Partials     1862     1864       +2     
Flag Coverage Δ
javascript 52.82% <100.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/SqlLab/components/SaveDatasetModal/index.tsx 52.87% <100.00%> (ø)
...frontend/src/components/ListView/Filters/index.tsx 52.17% <0.00%> (-14.50%) :arrow_down:
...src/dashboard/components/PropertiesModal/index.tsx 61.07% <0.00%> (-0.75%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 20 '22 12:09 codecov[bot]

/testenv up

yousoph avatar Sep 21 '22 18:09 yousoph

@yousoph Ephemeral environment spinning up at http://35.90.85.142:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar Sep 21 '22 19:09 github-actions[bot]

Looks good to me! Thanks for the fix, @EugeneTorap !!

yousoph avatar Sep 21 '22 20:09 yousoph

Ephemeral environment shutdown and build artifacts deleted.

github-actions[bot] avatar Sep 21 '22 20:09 github-actions[bot]