superset
superset copied to clipboard
fix(datasets): Stop showing alert when saving from query
SUMMARY
When user saves from a query we should not display the alert saying that changes were retained. (Blue message)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
- Create a chart from SQL Lab with source = query
- Save the dataset in Explore
ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
/testenv up
@yousoph Ephemeral environment spinning up at http://34.220.8.160:8080. Credentials are admin
/admin
. Please allow several minutes for bootstrapping and startup.
Codecov Report
Merging #21442 (d3d40a6) into master (9c285da) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #21442 +/- ##
=======================================
Coverage 66.53% 66.53%
=======================================
Files 1791 1791
Lines 68599 68599
Branches 7320 7320
=======================================
Hits 45645 45645
Misses 21064 21064
Partials 1890 1890
Flag | Coverage Δ | |
---|---|---|
javascript | 52.75% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
.../src/explore/components/ControlPanelsContainer.tsx | 80.15% <ø> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Ephemeral environment shutdown and build artifacts deleted.