superset icon indicating copy to clipboard operation
superset copied to clipboard

fix: Dataset duplication fatal error

Open reesercollins opened this issue 2 years ago • 3 comments

SUMMARY

Minor fix for dataset duplication.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

image

TESTING INSTRUCTIONS

Try duplicating a dataset. It should work now.

ADDITIONAL INFORMATION

  • [x] Has associated issue: #21281
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

reesercollins avatar Sep 07 '22 16:09 reesercollins

Codecov Report

Merging #21358 (480de44) into master (ce3d38d) will decrease coverage by 0.02%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21358      +/-   ##
==========================================
- Coverage   66.61%   66.59%   -0.03%     
==========================================
  Files        1791     1791              
  Lines       68481    68481              
  Branches     7299     7299              
==========================================
- Hits        45617    45603      -14     
- Misses      20978    20998      +20     
+ Partials     1886     1880       -6     
Flag Coverage Δ
javascript 52.73% <ø> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 57.73% <ø> (ø)
...rd/components/nativeFilters/FilterBar/keyValue.tsx 18.51% <0.00%> (-22.23%) :arrow_down:
...board/components/nativeFilters/FilterBar/index.tsx 60.14% <0.00%> (-5.80%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 07 '22 19:09 codecov[bot]

/testenv up

eschutho avatar Sep 27 '22 16:09 eschutho

@eschutho Ephemeral environment spinning up at http://35.86.77.230:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar Sep 27 '22 17:09 github-actions[bot]

LGTM

sadpandajoe avatar Sep 27 '22 17:09 sadpandajoe

@eschutho Can you update the description and write 'Fix #21281' to auto close the GitHub issue?

EugeneTorap avatar Sep 27 '22 17:09 EugeneTorap

Ephemeral environment shutdown and build artifacts deleted.

github-actions[bot] avatar Sep 27 '22 20:09 github-actions[bot]

🏷️ preset:2022.39

sadpandajoe avatar Oct 03 '22 17:10 sadpandajoe