superset icon indicating copy to clipboard operation
superset copied to clipboard

fix(explore): Dashboard list is unsorted in save modal

Open agl-developer opened this issue 3 years ago • 4 comments

SUMMARY

Listed dashboards in the save chart modal should show up alphabetically.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: Screen Shot 2022-08-09 at 10 07 47 AM

After: image

TESTING INSTRUCTIONS

  • Click on 'Charts' in the top menu bar
  • Select an existing chart.
  • Click on the 'Save' button on the top right.
  • Expand the dropdown under 'Add to Dashboard'

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

agl-developer avatar Sep 03 '22 00:09 agl-developer

Codecov Report

Merging #21317 (c90e223) into master (4c17f0e) will increase coverage by 0.01%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master   #21317      +/-   ##
==========================================
+ Coverage   66.82%   66.84%   +0.01%     
==========================================
  Files        1798     1798              
  Lines       68827    68829       +2     
  Branches     7333     7333              
==========================================
+ Hits        45997    46012      +15     
+ Misses      20951    20932      -19     
- Partials     1879     1885       +6     
Flag Coverage Δ
javascript 53.20% <50.00%> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-frontend/src/explore/actions/saveModalActions.js 97.26% <50.00%> (-1.34%) :arrow_down:
...board/components/nativeFilters/FilterBar/index.tsx 66.18% <0.00%> (+5.75%) :arrow_up:
...rd/components/nativeFilters/FilterBar/keyValue.tsx 40.74% <0.00%> (+22.22%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 03 '22 01:09 codecov[bot]

/testenv up

geido avatar Sep 08 '22 11:09 geido

@geido Ephemeral environment spinning up at http://35.86.118.87:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar Sep 08 '22 14:09 github-actions[bot]

@michael-s-molina I'd like your opinion here. I don't think this problem is related to this PR but testing with numeric dashboards I am getting an unwanted behaviour. I believe this could be the same problem that was reported elsewhere. Probably worth having a sync session about it.

Screenshot 2022-09-12 at 14 25 28

geido avatar Sep 12 '22 11:09 geido

@agl-developer Would you mind updating saveModalActions.test.js so sorting gets a little testing?

codyml avatar Sep 28 '22 00:09 codyml

Ephemeral environment shutdown and build artifacts deleted.

github-actions[bot] avatar Oct 03 '22 14:10 github-actions[bot]