feat: Dataset Creation Footer Component

[AAfghahi]

SUMMARY

This creates the footer component for the new dataset creation flow. Currently it does not set the name of the dataset, so default naming is used. However, this will be added after this: https://github.com/apache/superset/pull/21189 is merged in.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

https://user-images.githubusercontent.com/48933336/189211819-fd362415-f012-4ced-93c2-08289ba74acc.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• [ ] Has associated issue:
• [ ] Required feature flags:
• [ ] Changes UI
• [ ] Includes DB Migration (follow approval process in SIP-59)
  • [ ] Migration is atomic, supports rollback & is backwards-compatible
  • [ ] Confirm DB migration upgrade and downgrade tested
  • [ ] Runtime estimates and downtime expectations provided
• [ ] Introduces new feature or API
• [ ] Removes existing feature or API

[codecov[bot]]

Codecov Report

Merging #21241 (8e2b2c1) into master (f27e20e) will decrease coverage by 0.02%. The diff coverage is 52.83%.

@@            Coverage Diff             @@
##           master   #21241      +/-   ##
==========================================
- Coverage   66.66%   66.64%   -0.03%     
==========================================
  Files        1793     1793              
  Lines       68499    68852     +353     
  Branches     7278     7415     +137     
==========================================
+ Hits        45666    45886     +220     
- Misses      20969    21067      +98     
- Partials     1864     1899      +35     

Flag	Coverage Δ
hive	53.08% <ø> (ø)
javascript	52.88% <52.83%> (+0.06%)	:arrow_up:
mysql	78.20% <ø> (ø)
postgres	78.27% <ø> (ø)
presto	52.98% <ø> (ø)
python	81.41% <ø> (ø)
sqlite	76.76% <ø> (ø)
unit	51.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...iews/CRUD/data/dataset/AddDataset/Footer/index.tsx	33.33% <33.33%> (-66.67%)	:arrow_down:
...s/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx	47.61% <54.54%> (+0.34%)	:arrow_up:
superset-frontend/src/logger/LogUtils.ts	96.00% <100.00%> (+1.26%)	:arrow_up:
...d/src/views/CRUD/data/dataset/AddDataset/index.tsx	52.94% <100.00%> (+10.08%)	:arrow_up:
...set-frontend/src/views/CRUD/data/dataset/styles.ts	100.00% <100.00%> (ø)
superset-frontend/src/SqlLab/constants.ts	100.00% <0.00%> (ø)
...src/dashboard/components/PropertiesModal/index.tsx	61.97% <0.00%> (+0.15%)	:arrow_up:
...et-frontend/src/components/TableSelector/index.tsx	80.00% <0.00%> (+4.00%)	:arrow_up:
...frontend/src/SqlLab/components/SqlEditor/index.jsx	56.90% <0.00%> (+5.48%)	:arrow_up:
...tend/plugins/plugin-chart-table/src/TableChart.tsx	48.33% <0.00%> (+7.87%)	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[pkdotson]

/testenv up

[github-actions[bot]]

@pkdotson Container image not yet published for this PR. Please try again when build is complete.

[github-actions[bot]]

@pkdotson Ephemeral environment creation failed. Please check the Actions logs for details.

[AAfghahi]

/testenv up

[github-actions[bot]]

@AAfghahi Ephemeral environment spinning up at http://54.184.221.243:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[jinghua-qa]

Found 2 issues: 1, there is empty line between the search box and the table list, is this expected?

2, when user searched a non-existed table name and deleted the name before table list refresh, the selected database table section will be refreshed too, is this expected?

https://user-images.githubusercontent.com/81597121/190326724-f2fbd677-309a-4441-afe2-c22bca78feb9.mov

[jinghua-qa]

One more suggestion: can we add a delete button to remove search word in the search box?

[lyndsiWilliams]

2, when user searched a non-existed table name and deleted the name before table list refresh, the selected database table section will be refreshed too, is this expected?

delete.table.search.mov

@jinghua-qa The left panel initially used server side searching, which may have cause this. Server side searching was disabled recently so currently the table search isn't working. I'll be fixing the search so that it uses client side searching in my next PR, I will watch for this behavior while I'm fixing it but the search will not work in this PR.

For clarity: The entire table list should still display once a schema is chosen, you just can't search through it until my next fix PR.

[lyndsiWilliams]

/testenv up

[github-actions[bot]]

@lyndsiWilliams Ephemeral environment spinning up at http://35.92.221.221:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[lyndsiWilliams]

@jinghua-qa I addressed all your comments above, could you take a look and make sure everything looks right now?

[jinghua-qa]

Re-test in http://35.92.221.221:8080/, find an issue that the table list did not change with the search keyword: repo steps: 1, input keyword in the search box expect: table list will show match result with keyword actual: table list did not change

https://user-images.githubusercontent.com/81597121/191912112-6f254ee8-397d-45ce-b235-7bd516f24058.mov

[lyndsiWilliams]

Re-test in http://35.92.221.221:8080/, find an issue that the table list did not change with the search keyword: repo steps: 1, input keyword in the search box expect: table list will show match result with keyword actual: table list did not change

Screen.Recording.2022-09-23.at.12.32.23.AM.mov

Yes, I mentioned this a couple of comments above. Server side searching was disabled recently so currently the table search isn't working. I'll be fixing the search so that it uses client side searching in my next PR.

[jinghua-qa]

Re-test in http://35.92.221.221:8080/, find an issue that the table list did not change with the search keyword: repo steps: 1, input keyword in the search box expect: table list will show match result with keyword actual: table list did not change Screen.Recording.2022-09-23.at.12.32.23.AM.mov

Yes, I mentioned this a couple of comments above. Server side searching was disabled recently so currently the table search isn't working. I'll be fixing the search so that it uses client side searching in my next PR.

Sorry have missed your previous comment, i think other than that i did not find other issues~ LGTM

[github-actions[bot]]

Ephemeral environment shutdown and build artifacts deleted.