fix(sql-lab): Allow User Impersonation in SQL Lab

Open rickysaltzer opened this issue 3 years ago • 1 comments

Previously, when users execute an ad-hoc query through the SQL lab interface, their username was not provided, and the current_user global was not available. This resulted in the error described in #20455
This patch provides the DB_CONNECTION_MUTATOR override the user executing the ad-hoc query so that their credentials can be properly looked up.

Implement DB_CONNECTION_MUTATOR method to enable user impersonation when executing ad-hoc queries. Then, issue a query from the SQL-Lab page.

[x] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Aug 19 '22 16:08 rickysaltzer

does it work?

Nov 22 '22 17:11 tooptoop4