superset
superset copied to clipboard
fix(dashboard): Fix scroll behaviour in DashboardBuilderSidepane
Fix wrong scroll behaviour in CHARTS
tab on DashboardBuilder
BEFORE
https://user-images.githubusercontent.com/29536522/182790268-5a25504a-db20-4658-94cc-147e89698346.mov
AFTER
https://user-images.githubusercontent.com/29536522/182790485-6b356690-5d2b-40d5-b4d8-71498704adb7.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API @michael-s-molina @kgabryje @lyndsiWilliams
Codecov Report
Merging #20969 (a913b18) into master (e214e1a) will increase coverage by
0.03%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #20969 +/- ##
==========================================
+ Coverage 66.34% 66.37% +0.03%
==========================================
Files 1767 1767
Lines 67312 67271 -41
Branches 7144 7147 +3
==========================================
- Hits 44656 44653 -3
+ Misses 20828 20790 -38
Partials 1828 1828
Flag | Coverage Δ | |
---|---|---|
javascript | 52.11% <100.00%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...ashboard/components/BuilderComponentPane/index.tsx | 76.47% <100.00%> (-2.48%) |
:arrow_down: |
superset/views/core.py | 75.52% <0.00%> (ø) |
|
...chart-echarts/src/Timeseries/EchartsTimeseries.tsx | 0.00% <0.00%> (ø) |
|
...set-frontend/src/components/Select/AsyncSelect.tsx | 83.26% <0.00%> (+0.07%) |
:arrow_up: |
superset-frontend/src/components/Select/Select.tsx | 87.16% <0.00%> (+0.08%) |
:arrow_up: |
superset/common/query_context_processor.py | 90.00% <0.00%> (+0.71%) |
:arrow_up: |
...frontend/src/SqlLab/components/ResultSet/index.tsx | 51.70% <0.00%> (+1.00%) |
:arrow_up: |
superset/models/helpers.py | 40.78% <0.00%> (+1.37%) |
:arrow_up: |
superset/models/sql_lab.py | 78.75% <0.00%> (+1.73%) |
:arrow_up: |
.../src/components/Select/WindowedSelect/windowed.tsx | 72.72% <0.00%> (+2.72%) |
:arrow_up: |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
@michael-s-molina @kgabryje @lyndsiWilliams @hughhhh Can you review it?
/testenv up
@kgabryje Ephemeral environment spinning up at http://34.220.145.169:8080. Credentials are admin
/admin
. Please allow several minutes for bootstrapping and startup.
/testenv down