superset
superset copied to clipboard
chore: add test for tab state
This PR adds a test for https://github.com/apache/superset/pull/20947 which was a fix for breaking cypress tests on CI. We wanted to make sure that both params were allowed by the api (name and title) for backward compatibility
ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
Codecov Report
Merging #20949 (18001ac) into master (ac58582) will increase coverage by
0.00%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #20949 +/- ##
=======================================
Coverage 66.38% 66.38%
=======================================
Files 1766 1766
Lines 67224 67224
Branches 7135 7135
=======================================
+ Hits 44625 44630 +5
+ Misses 20774 20769 -5
Partials 1825 1825
| Flag | Coverage Δ | |
|---|---|---|
| hive | 53.20% <ø> (ø) |
|
| mysql | 81.03% <ø> (+0.01%) |
:arrow_up: |
| postgres | 81.10% <ø> (+0.01%) |
:arrow_up: |
| presto | 53.10% <ø> (ø) |
|
| python | 81.58% <ø> (+0.01%) |
:arrow_up: |
| sqlite | 79.69% <ø> (+0.01%) |
:arrow_up: |
| unit | 50.52% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| superset/views/sql_lab.py | 63.81% <0.00%> (+3.28%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.