superset icon indicating copy to clipboard operation
superset copied to clipboard

feat(helm): add liveness and readiness for deployment webserver

Open jplanckeel opened this issue 2 years ago • 6 comments

SUMMARY

We want add readiness and liveness in helmchart because we need liveness to restart container automatically when server crash and readiness for to delay start.

Is best practice in K8s to have liveness and readiness. :)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

jplanckeel avatar Jun 30 '22 13:06 jplanckeel

Still needs a version bump

craig-rueda avatar Jul 07 '22 16:07 craig-rueda

Still needs a version bump

We can automate bump version, in my entreprise we automate bump version with label bump:minor, bump:major, bump;patch. is more easier and reduce error to bump version.

jplanckeel avatar Jul 08 '22 07:07 jplanckeel

You need to update the schema to get CI passing https://github.com/apache/superset/blob/7f918a4ec0e162be13bf3fc0e2f15aaaa5450cec/helm/superset/values.schema.json#L2

nytai avatar Jul 12 '22 05:07 nytai

Hi, i updated values schema, can you merge this PR ?

jplanckeel avatar Jul 20 '22 11:07 jplanckeel

Hi, any update on this ?

gforien avatar Jul 25 '22 13:07 gforien

I've got also one more question. Is not liveness/readiness probe also needed for rest Superset's elements (worker and celerybeat)?

wiktor2200 avatar Aug 05 '22 11:08 wiktor2200

I've got also one more question. Is not liveness/readiness probe also needed for rest Superset's elements (worker and celerybeat)?

we can do this step by step, the PR is already open for several weeks.

For the workers, do we have a status endpoint or a command to check the functioning? same for celery

jplanckeel avatar Aug 08 '22 13:08 jplanckeel