superset
superset copied to clipboard
feat(helm): add liveness and readiness for deployment webserver
SUMMARY
We want add readiness and liveness in helmchart because we need liveness to restart container automatically when server crash and readiness for to delay start.
Is best practice in K8s to have liveness and readiness. :)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
Still needs a version bump
Still needs a version bump
We can automate bump version, in my entreprise we automate bump version with label bump:minor, bump:major, bump;patch. is more easier and reduce error to bump version.
You need to update the schema to get CI passing https://github.com/apache/superset/blob/7f918a4ec0e162be13bf3fc0e2f15aaaa5450cec/helm/superset/values.schema.json#L2
Hi, i updated values schema, can you merge this PR ?
Hi, any update on this ?
I've got also one more question. Is not liveness/readiness probe also needed for rest Superset's elements (worker and celerybeat)?
I've got also one more question. Is not liveness/readiness probe also needed for rest Superset's elements (worker and celerybeat)?
we can do this step by step, the PR is already open for several weeks.
For the workers, do we have a status endpoint or a command to check the functioning? same for celery