superset
superset copied to clipboard
apache
Annotations intermittently fail to display for many chart types
When adding Event or Interval annotations creates a chart that intermittently fails to render for many chart types.
How to reproduce the bug
Chart types I've confirmed this does happen with: Time-series Line Chart, Time-series Area Chart, Time-series Bar Chart v2, Mixed Time Series Chart types I've confirmed this does not happen with: Line Chart, Bar Chart
Annotations types I've confirmed this does happen with: Event (with Superset Annotation Source), Interval (with Superset Annotation Source) Annotations types I've confirmed this does not happen with: Formula
- Go to 'Create New Chart'
- Click on 'Time-series Line Chart'
- Choose a dataset
- Drag in a metric (e.g. the default count)
- Click Annotations and Layers
- Click Add annotation Layer
- Select 'Interval' for the annotation type
- Type anything for the name, e.g. "foobar"
- Select 'superset annotation' from the annotation source
- Select an annotation layer
- Click 'OK'
- Click 'Create Chart' <-- Sometimes this will trigger the issue
- Type a name for the chart in the top left box (e.g. "foo bar")
- Click "Save" and confirm the Save <-- This generally triggers the issue
Expected results
I expect a chart to be displayed with areas blocked out.
Actual results
An "Unexpected error" box is displayed.
Looking at the console it appears the data to load the graph is not fully loaded into the front end.
The bug is intermittent occurring ~90% of the time.
Environment
(please complete the following information):
- browser type and version: Chrome 102.0.5005.115
- superset version: 0.0.0dev (helm default)
- python version: 3.8.12
- node.js version: Node not installed
- any feature flags active: DASHBOARD_RBAC
Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [X] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [X] I have reproduced the issue with at least the latest released version of superset.
- [X] I have checked the issue tracker for the same issue and I haven't found one similar.
Additional context
Add any other context about the problem here.
I just experienced this too when attempting to come up with a POC for my company, sharing more of my observations for what its worth.
It starts to happen once I've saved a chart with annotations. In this case I'm using Time-series Bar Chart v2 as mentioned above.
If I open the Annotation modal and hit Apply or OK the query goes through and the chart reloads with no issues
However once I hit "Save" for the chart in the top right the query stops working once more.
This also affects the same chart inside a dashboard:
Environment
browser type and version: Version 103.0.5060.53 superset version: 0.0.0dev (docker image from https://hub.docker.com/r/apache/superset) python version: 3.8.13 node.js version: Node not installed any feature flags active: DASHBOARD_CROSS_FILTERS
couldn't reproduce in latest master (last commit sha: 8f74e46d45ca94f5656f7b881f1096c16657c829)
used time series line chart, superset annotation for interval.
possible to test this on latest master?
Looks fixed on my end! I'm not seeing this any more on the latest docker tag
