superset icon indicating copy to clipboard operation
superset copied to clipboard

feat: Virtual dataset duplication

Open reesercollins opened this issue 2 years ago • 3 comments

SUMMARY

There is currently no way for users to copy datasets in superset. Even though they can copy the SQL of a dataset, any changes we make to the field types (e.g., in cases where we turn long, complex types into JSON, or advanced types as described in #17852) cannot be easily copied.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

See #20245

TESTING INSTRUCTIONS

There should be a button in the actions column for virtual datasets which duplicates them with the provided name when clicked.

ADDITIONAL INFORMATION

  • [x] Has associated issue: #20232
  • [ ] Required feature flags:
  • [x] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [x] Introduces new feature or API
  • [ ] Removes existing feature or API

reesercollins avatar Jun 08 '22 13:06 reesercollins

Codecov Report

Merging #20309 (bcf7244) into master (0945d4a) will increase coverage by 0.19%. The diff coverage is 66.21%.

:exclamation: Current head bcf7244 differs from pull request most recent head 5f74040. Consider uploading reports for the commit 5f74040 to get more accurate results

@@            Coverage Diff             @@
##           master   #20309      +/-   ##
==========================================
+ Coverage   66.17%   66.36%   +0.19%     
==========================================
  Files        1757     1767      +10     
  Lines       66867    67153     +286     
  Branches     7077     7132      +55     
==========================================
+ Hits        44246    44563     +317     
+ Misses      20812    20765      -47     
- Partials     1809     1825      +16     
Flag Coverage Δ
javascript 52.13% <56.80%> (+0.18%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/packages/superset-ui-chart-controls/src/types.ts 100.00% <ø> (ø)
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
...tend/plugins/plugin-chart-handlebars/src/consts.ts 66.66% <ø> (-8.34%) :arrow_down:
...lugin-chart-handlebars/src/plugin/controlPanel.tsx 50.00% <ø> (-16.67%) :arrow_down:
...hart-pivot-table/src/react-pivottable/utilities.js 0.00% <0.00%> (ø)
...nd/plugins/plugin-chart-table/src/controlPanel.tsx 45.58% <ø> (-0.79%) :arrow_down:
...frontend/src/SqlLab/components/SqlEditor/index.jsx 51.36% <0.00%> (ø)
...d/src/SqlLab/components/TabbedSqlEditors/index.jsx 56.11% <ø> (ø)
...et-frontend/src/SqlLab/reducers/getInitialState.js 46.42% <ø> (ø)
superset-frontend/src/SqlLab/reducers/sqlLab.js 33.33% <ø> (ø)
... and 153 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

codecov[bot] avatar Jun 22 '22 18:06 codecov[bot]

/testenv up

yousoph avatar Jun 29 '22 18:06 yousoph

@yousoph Ephemeral environment spinning up at http://52.88.76.216:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar Jun 29 '22 18:06 github-actions[bot]

Ephemeral environment shutdown and build artifacts deleted.

github-actions[bot] avatar Aug 26 '22 22:08 github-actions[bot]