superset icon indicating copy to clipboard operation
superset copied to clipboard

chore: bumping react-markdown to ^5.0.3 for downstream dependencies

Open rusackas opened this issue 3 years ago • 2 comments

SUMMARY

Wanted to bump this package in order to bump it's innards. According to the changelog, this should be no biggie.

Pasted_Image_4_26_22__9_44_PM

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Spin up a test env, and make sure markdown components don't fail spectacularly :)

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

rusackas avatar Apr 27 '22 03:04 rusackas

Codecov Report

Merging #19860 (ff24e41) into master (4fcc1d9) will decrease coverage by 0.16%. The diff coverage is n/a.

:exclamation: Current head ff24e41 differs from pull request most recent head 536cefc. Consider uploading reports for the commit 536cefc to get more accurate results

@@            Coverage Diff             @@
##           master   #19860      +/-   ##
==========================================
- Coverage   66.67%   66.51%   -0.17%     
==========================================
  Files        1791     1714      -77     
  Lines       68459    65027    -3432     
  Branches     7268     6711     -557     
==========================================
- Hits        45643    43250    -2393     
+ Misses      20955    20070     -885     
+ Partials     1861     1707     -154     
Flag Coverage Δ
hive 52.91% <ø> (-0.13%) :arrow_down:
mysql 81.91% <ø> (+3.73%) :arrow_up:
postgres 81.96% <ø> (+3.71%) :arrow_up:
presto 52.76% <ø> (-0.18%) :arrow_down:
python 82.39% <ø> (+0.99%) :arrow_up:
sqlite 81.73% <ø> (+4.98%) :arrow_up:
unit 47.99% <ø> (-3.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/setup/setupFormatters.ts 0.00% <0.00%> (-100.00%) :arrow_down:
.../shared-controls/components/RadioButtonControl.tsx 0.00% <0.00%> (-83.34%) :arrow_down:
...hart-table/src/DataTable/utils/getScrollBarSize.ts 7.14% <0.00%> (-78.58%) :arrow_down:
...t-frontend/src/components/DropdownButton/index.tsx 10.00% <0.00%> (-75.00%) :arrow_down:
superset-frontend/src/setup/setupClient.ts 0.00% <0.00%> (-70.00%) :arrow_down:
...qlLab/components/EstimateQueryCostButton/index.tsx 5.26% <0.00%> (-58.38%) :arrow_down:
...et-frontend/src/dashboard/actions/sliceEntities.js 16.00% <0.00%> (-58.29%) :arrow_down:
...nd/plugins/plugin-chart-table/src/controlPanel.tsx 16.66% <0.00%> (-46.30%) :arrow_down:
superset-frontend/src/preamble.ts 0.00% <0.00%> (-46.16%) :arrow_down:
...t-frontend/src/explore/actions/saveModalActions.js 59.09% <0.00%> (-39.38%) :arrow_down:
... and 760 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Apr 27 '22 03:04 codecov[bot]

Unit tests failing spectacularly... so much for easy!

rusackas avatar Apr 28 '22 17:04 rusackas