superset icon indicating copy to clipboard operation
superset copied to clipboard

fix(helm): add nodeselector and tolerations to init job

Open jakedsouza opened this issue 3 years ago • 5 comments

SUMMARY

  • Fixes issue #18004 adding a node selector and toleration to the init job configurable in the values file.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

  • Set the nodeselector, toleration and affinity to the init block in the values.yaml file.
  ## Node selector to be added to init job pods
  nodeSelector:
    role: test-nodeselector
  ## Tolerations to be added to init job pods
  tolerations:
      - key: role
        operator: Equal
        value: test-toleration
  ## Affinity to be added to init job pods
  affinity: {}

ADDITIONAL INFORMATION

  • [x] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

jakedsouza avatar Jan 17 '22 08:01 jakedsouza

@nytai @zhaoyongjie @craig-rueda the linter is failing due to a chart version mismatch, should I bump the version to 0.5.6

jakedsouza avatar Feb 07 '22 18:02 jakedsouza

Hello

I have exactly the same problem

Can you apply this modification in the next version of the chart?

olahouze avatar Apr 11 '22 14:04 olahouze

Im with the same problem :(

NephilimJaeger avatar Oct 04 '22 21:10 NephilimJaeger

It looks like this PR still needs a version bump.

eschutho avatar Oct 18 '22 21:10 eschutho

@zhaoyongjie Can we merge it?

EugeneTorap avatar Nov 23 '22 03:11 EugeneTorap

@jakedsouza why was the PR closed?

losblancoo avatar Mar 15 '23 12:03 losblancoo

I have applied the toleration and nodeSelector to the pods. all pods have the desired toleration and nodeSelector except for Redis pod. I haven't set up any caching config. it is deployed as it is in the 'values.yaml' file. What needs to be done to apply these setting to Redis pod?

asayeb avatar Jul 05 '23 13:07 asayeb

Hi,

I setup: nodeSelector: nodetype: core-ccx23

but it applies only for superset and worker.

Redis and Postgresql with out node-selector.

How to fix that?

maximdogonov avatar Mar 07 '24 09:03 maximdogonov