superset icon indicating copy to clipboard operation
superset copied to clipboard

deck.gl Polygon does not work when column name is "Polygon" or "polygon"

Open sarthak opened this issue 3 years ago • 3 comments

deck.gl Polygon chart does not appear to work when the column name corresponding to polygon is 'Polygon' or 'polygon'.

Expected results

A polygon to be rendered.

Actual results

Error message An error occurred while rendering the visualization: TypeError: right-hand side of 'in' should be an object, got undefined.

Screenshots

Not needed

How to reproduce the bug

  1. Go to SQL Lab > Query Editor
  2. Type this query
SELECT '[[-106.69921875,46.92025531537451],[-116.19140625,37.996162679728116],[-90.17578124999999,32.99023555965106],[-106.69921875,46.92025531537451]]'
AS polygon
  1. Click Run and then Explore
  2. Select chart type as deck.gl Polygon, and polygon column as polygon.
  3. Press Run, error message will be displayed
  4. Now, click on edit dataset, press the lock icon
  5. Change the query by renaming polygon -> contour
  6. Click Save
  7. Click again on edit dataset, and go to columns and click sync columns from source, then click save again
  8. Go back to chart and change polygon column to contour.
  9. Re run the chart, now a triangle should be visible over the united states.

Environment

Using docker-compose, so latest version from master.

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • [x] I have reproduced the issue with at least the latest released version of superset.
  • [x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

This is a serious issue, for a chart called deck.gl polygon, a column name polygon not working is deal breaker.

sarthak avatar Jul 30 '21 05:07 sarthak

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

stale[bot] avatar Apr 17 '22 21:04 stale[bot]

I'm getting this error on a bar chart v2, as the result of adding annotations. Did you have annotations on this chart?

My annotation event looks great on the chart, including when I click "Update Chart." Then I hit save and get this error.

sfirke avatar Sep 08 '22 15:09 sfirke

Is anyone still experiencing this in Superset 3.x? I'm quite tempted to close this as stale, but it seems like just an edge case that likely hasn't been fixed. Not sure the repro steps for the bar chart bug — is that also failing with a column named "polygon" or is that a separate thing?

rusackas avatar Feb 12 '24 20:02 rusackas

Closing this as stale, but happy to revisit/reopen if folks are still facing this in 4.x. Maybe @dosu-bot can leave some helpful thoughts here as well, just for good measure :)

rusackas avatar Jun 10 '24 19:06 rusackas