superset icon indicating copy to clipboard operation
superset copied to clipboard

feat: Draft drilldown POC

Open zhaoyongjie opened this issue 3 years ago • 18 comments

SUMMARY

This PR introduces drilldown on explore and dashboard. notice that drilldown is an experimental feature.

Associated PR in superset-ui: https://github.com/apache-superset/superset-ui/pull/1120

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Drilldown on explore

https://user-images.githubusercontent.com/2016594/118643365-0bfbbe80-b80f-11eb-9647-f960f6d70d3a.mp4

Drilldown on dashboard

https://user-images.githubusercontent.com/2016594/118643385-1322cc80-b80f-11eb-8ace-27d95b01e023.mp4

TEST PLAN

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [x] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [x] Introduces new feature or API
  • [ ] Removes existing feature or API

zhaoyongjie avatar May 18 '21 11:05 zhaoyongjie

Look forword to this feat.

skymarstroy avatar May 26 '21 07:05 skymarstroy

This looks great. Besides the related PR in superset-ui, does anything else need to be done before this is merged?

jhult avatar Jul 20 '21 11:07 jhult

Hi @ skymarstroy @jhult , This feature needs more design. I will update this PR soon. Thank you for your interest! cc @junlincc

zhaoyongjie avatar Jul 20 '21 13:07 zhaoyongjie

hi @zhaoyongjie, I modified my files according to the code mentioned,but there are something wrong:

98% after emitting SizeLimitsPluginERROR in D:/superset_1.3/superset/superset-frontend/src/explore/components/controls/DrillDownControl/DrillDownControl.tsx(23,10): TS2305: Module '"@superset-ui/core"' has no exported member 'DrillDown'.

what can I do? thank you very much

superset 1.3

walkmansun avatar Aug 26 '21 15:08 walkmansun

Is going in anytime soon? We'd love to use this functionality and considering hacking it together ourselves if this is not a priority/on the roadmap.

Vygo avatar Aug 31 '21 21:08 Vygo

how to add drilldown feat to 'mixed time series' chat,I tried your method(eg: echat-pie),but it doesn't work

junryan avatar Nov 08 '21 05:11 junryan

Hi, is drill down feature usable in version 1.3?

caladogan avatar Nov 30 '21 15:11 caladogan

For those following this PR, I have taken the liberty of bringing this feature up-to-date with the fairly recent superset reorg into a mono repo. I've also extended the functionality to work the bar charts. Those changes are in #17883.

EvilDrW avatar Dec 28 '21 21:12 EvilDrW

Is this drilldown feature got released ?

sujithzebpay avatar Jan 21 '22 06:01 sujithzebpay

Can we please have this released? It's a critical feature we need , awesome addition

noureentaj avatar Mar 02 '22 12:03 noureentaj

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

stale[bot] avatar May 01 '22 12:05 stale[bot]

will this be released?

HeathLee avatar Jun 17 '22 04:06 HeathLee

will this be released?

Superset3.0 might release this.

zhaoyongjie avatar Jun 17 '22 04:06 zhaoyongjie

Superset 3.0 might be quite a while. Can we have this in a 2.x please? This is one of the highly requested features by our customers and PR looks good in video!

bnitesh avatar Jun 29 '22 16:06 bnitesh

@zhaoyongjie @superset-ui/core/DrillDown is not available in version 0.17.46, why do you can import?:smile:

xinchanghao avatar Sep 07 '22 10:09 xinchanghao

Hi @xinchanghao, the superset-ui had been part of the superset repo. This PR is going to implement in the master in the future.

zhaoyongjie avatar Sep 07 '22 12:09 zhaoyongjie

Hi @xinchanghao, the superset-ui had been part of the superset repo. This PR is going to implement in the master in the future.

I see. Thank you 😃

xinchanghao avatar Sep 07 '22 12:09 xinchanghao

Any ETA of the release?

cue-parashar avatar Sep 19 '22 05:09 cue-parashar

Would really love this feature. Hope there will be some progress soon

lf-floriandin avatar Dec 07 '22 13:12 lf-floriandin

I am also waiting for this feature on the master, I think Preset has lots of engineers tackling this one and will bring a fantastic Drill feature in the future. isn't it? @rusackas

zhaoyongjie avatar Dec 07 '22 14:12 zhaoyongjie

@zhaoyongjie thanks for your effort, so are you expecting your branch to be merged in the future? or someone from the preset will finally work on it and release this feature ?

muneebsajjad-zameen avatar Dec 08 '22 18:12 muneebsajjad-zameen

Indeed, I don't think we're going to merge this... I'll just close it, with a proper round of applause for @zhaoyongjie for proving out so much with this effort.

Preset (and anyone who want to join!) are working on a stepped approach to drilling. Drill to Details is already shipping, Drill By (where you pick any column to drill into) is in flight, and then the final step will be mapping hierarchical relationships at the semantic layer to enable more automagic drill-down/drill-up actions. There's always more to do here (chart support and so forth) so we welcome extra sets of hands in this effort! Hit me up on Slack if you want to coordinate!

rusackas avatar Dec 08 '22 23:12 rusackas

drill by is similar with cross-filter (drill-through)?

crazyisjen avatar Dec 16 '22 07:12 crazyisjen

drill by is similar with cross-filter (drill-through)?

Cross-filters are a different story entirely. Drill by is KIND OF like Drill Down, but instead of the right-click menu automatically knowing which filter+groupBy is "down" by knowing a hierarchy, drillBy lets you pick an arbitrary column to group by. This could be the next hierarchical layer, or... anything else.

I'll try to explain all this in a blogpost and/or meetup in the new year.

rusackas avatar Dec 23 '22 05:12 rusackas

awesome feature, looking forward to it @rusackas do you have any idea when this feature might be released?

strangerjam avatar Feb 06 '23 10:02 strangerjam

Not yet... as always, there's a competition for time/resource prioritization :)

rusackas avatar Feb 06 '23 18:02 rusackas

Any update on this topic ?

nomed avatar Jul 14 '23 22:07 nomed

Any update on this topic ?

You can now use DRILL_BY to drill into supported charts in dashboards. Preset's docs cover this pretty well, and there was a meetup that covers it too. The approach on this PR was a POC, but it was decided that specifying hierarchies for each and every chat was too much workflow overhead.

rusackas avatar Jul 15 '23 01:07 rusackas

@zhaoyongjie I want to modify dashboard native filters whenever using this drilldown feature. Can you please help me with that. email: [email protected]

sundar68 avatar Mar 21 '24 15:03 sundar68

@rusackas @zhaoyongjie Will we get this feature in the future? We eagerly waiting for drill down / drill up feature. Current drill to details and drill by features are working only on the same database table while we need drill down to another table.

nitin-kumar12 avatar Jun 11 '24 11:06 nitin-kumar12