struts icon indicating copy to clipboard operation
struts copied to clipboard

Published 20 hours ago • verified publisher icon apache

WW-5196 use generics for RequestMap and ApplicationMap and correct SessionMap to also be of type <String, Object>

Open sdutry opened this issue 2 years ago • 4 comments

Assumption:

  • keys will always be Strings

Extracted abstract class for similar logic for entries

Resolves WW-5196

sdutry avatar Aug 06 '22 18:08 sdutry

Coverage Status

Coverage increased (+0.008%) to 50.669% when pulling 6ba4432fbe8c88cd2569e7a705bd716dd0723768 on sdutry:issue/WW-5196 into de3dabbe443ae70c083f7313ba0bd74f0a3222e5 on apache:master.

coveralls avatar Aug 06 '22 18:08 coveralls

Nice 👏 but I would wait with merging this till 6.0.1 is out.

lukaszlenart avatar Aug 07 '22 08:08 lukaszlenart

Sure, no problem with waiting, just wondering if i should adjust SessionMap accordingly since, as far as i can see, it should only have String keys too.

sdutry avatar Aug 07 '22 14:08 sdutry

just wondering if i should adjust SessionMap accordingly since, as far as i can see, it should only have String keys too.

Yes, please - adjust description of the ticket as well, thanks a lot!

lukaszlenart avatar Aug 08 '22 11:08 lukaszlenart

LGTM

kusalk avatar Mar 04 '23 02:03 kusalk

@sdutry could you rebase this PR? We switched from Travis to GH Actions to validate PRs, thanks in advance!

lukaszlenart avatar Mar 11 '23 09:03 lukaszlenart

@lukaszlenart i'll der what i can do and if it's still relevant when i find a moment

sdutry avatar Mar 11 '23 11:03 sdutry

@sdutry Definitely still relevant as I was about to put up a PR for the same but then noticed yours. If you've no time I'd be happy to rebase it for you :)

kusalk avatar Mar 12 '23 08:03 kusalk

I'll try and do it tonight

sdutry avatar Mar 12 '23 09:03 sdutry

@lukaszlenart tried to merge in master to get it up to date again.

I had to change a test concerning the nonce in order to get that test running again, not comfortable with having to do a change there, don't think i touched anything there. (FreemarkerResultMockedTest.testNonce)

Can not get the java 11 build succeeding due to the following error :

Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184:sonar (default-cli) on project struts2-parent: Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties, the 'SONAR_TOKEN' environment variable, or contact the project administrator

sdutry avatar Mar 12 '23 20:03 sdutry

Can not get the java 11 build succeeding due to the following error :

Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184:sonar (default-cli) on project struts2-parent: Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties, the 'SONAR_TOKEN' environment variable, or contact the project administrator

Thanks a lot @sdutry the issue with JDK11 is related to GH Action token access and can be ignored.

lukaszlenart avatar Mar 13 '23 06:03 lukaszlenart