struts icon indicating copy to clipboard operation
struts copied to clipboard

WW-5184 - Add optional parameter value check to ParametersInterceptor

Open brianandle opened this issue 2 years ago • 4 comments

Implements WW-5184

  • Add optional parameter value check to ParametersInterceptor
  • Add Unit Tests

brianandle avatar Jun 05 '22 01:06 brianandle

Coverage Status

Coverage increased (+0.04%) to 50.675% when pulling 584634a9b5ed66eabc5655a49d704a7038bd1e27 on brianandle:WW-5184_v2 into 4b3ee53f939ac040b6d5351591eace6023d78514 on apache:master.

coveralls avatar Jun 05 '22 01:06 coveralls

@lukaszlenart, sorry just noticed the comment, so you're thinking of a ParameterValueAware similar to ParameterNameAware correct? If so I can work on that in the morning (I'm in PST timezone).

brianandle avatar Jun 08 '22 04:06 brianandle

Added ParameterValueAware interface and unit test

brianandle avatar Jun 08 '22 04:06 brianandle

I would postpone this change and introduce it into 6.1.0 - right now there is a few bugs targeting 6.0.1 which is a priority for me

lukaszlenart avatar Jun 15 '22 18:06 lukaszlenart

LGTM 👍

lukaszlenart avatar Sep 14 '22 14:09 lukaszlenart

@brianandle could you add this new options to https://struts.apache.org/core-developers/parameters-interceptor ? Thanks in advance!

lukaszlenart avatar Sep 14 '22 14:09 lukaszlenart

Sure. I'll work on that on Monday.


From: Lukasz Lenart @.> Sent: Wednesday, September 14, 2022 7:54 AM To: apache/struts @.> Cc: brianandle @.>; Mention @.> Subject: Re: [apache/struts] WW-5184 - Add optional parameter value check to ParametersInterceptor (PR #559)

@brianandlehttps://github.com/brianandle could you add this new options to https://struts.apache.org/core-developers/parameters-interceptor ? Thanks in advance!

— Reply to this email directly, view it on GitHubhttps://github.com/apache/struts/pull/559#issuecomment-1246892090, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZLWUEVT55DHCUZ7TR6V44TV6HRKDANCNFSM5X4H5MIA. You are receiving this because you were mentioned.Message ID: @.***>

brianandle avatar Sep 17 '22 02:09 brianandle

Created https://github.com/apache/struts-site/pull/170 for the doc changes

brianandle avatar Sep 19 '22 13:09 brianandle