struts
struts copied to clipboard
WW-4520 - Add prefix for CSS classes.
Struts-JDK7-pull-request #44 FAILURE Looks like there's a problem with this pull request
Christoph Nenning on [email protected] replies: Hi,
have you guys seen this jira and PR?
What do you think about the compatibility issues?
For me it would be OK to change it in 2.5, but it already scares me to migrate my own applications ;)
https://issues.apache.org/jira/browse/WW-4520 https://github.com/apache/struts/pull/44
regards, Christoph classes. feature/css-class-prefix your feature please ticket
This Email was scanned by Sophos Anti Virus
Lukasz Lenart on [email protected] replies: I think this too huge change and also would like to use some other prefix than "struts-" - it can expose too much information about used backend
2015-07-02 9:10 GMT+02:00 Christoph Nenning [email protected]:
Hm... I wonder how hard it will be to make this configurable so we can keep backward compatibility and allow enable a custom prefix on demand.
I wonder how hard it will be to make this configurable
Making this configurable would be cool. But when looking at changed files, and all those different file types, i fear it would be hard.
@apache/struts-committers , I'm going to close this one as already there are users mentioning such things as an information disclosure security issue. objections?
Hm.. I see Lukasz already has mentioned about that and also as mentioned, it should be user-configurable prefix to avoid information disclosure!
@aleksandr-m do you think it will be hard to update this PR? Or maybe create a new one?
@lukaszlenart You mean to allow to change prefix? Do you have an idea how to do that?
@lukaszlenart You mean to allow to change prefix? Do you have an idea how to do that?
Yes, I know we are supporting a different set of extensions and I do not have a solution at hand. Other option is to develop a new html5 theme from scratch.