streampipes icon indicating copy to clipboard operation
streampipes copied to clipboard

Enhance Static Properties by UI validation

Open bossenti opened this issue 1 year ago • 4 comments

Body

Currently, user input that is collected via the UI when configuring adapters & pipeline elements is not validated, e.g., for being an integer. This can lead to frustration for the end user. Therefore, we should try to build in validation for our static properties so that at least data types are validated automatically and maybe even additional validation criteria can be defined.

StreamPipes Committer

I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.

bossenti avatar Nov 06 '23 15:11 bossenti

Hi @bossenti, I looked at the adapters creation page and saw some validation is already in place. For example: image

Could you please clarify what properties you are referring to and where they can be found?

IsaakKrut avatar Dec 22 '23 00:12 IsaakKrut

Hi @IsaakKrut, can you please check if the validation also validates that the input is an integer? Is there an error message when you enter "9092.0"?

tenthe avatar Dec 22 '23 09:12 tenthe

@tenthe it does not, but it shows an error with exception stack trace when it tries to connect and guess the schema. I did find 3 adapters that do not have UI validation on their port fields: OPC UA, PLC4X MODBUS, ROS Bridge

IsaakKrut avatar Dec 22 '23 21:12 IsaakKrut

Ok great. Then this is a good starting point for this issue. Perhaps we can make a list of the places where validation does not work.

tenthe avatar Dec 27 '23 06:12 tenthe