streampipes icon indicating copy to clipboard operation
streampipes copied to clipboard

Remove legacy classes in `streampipes-rest-shared`

Open tenthe opened this issue 2 years ago • 2 comments

Body

Clean up module streampipes-rest-shared.

  • The interface NoAuthenticationRequired does not seem to be used anywhere. Can we remove it?
  • Tha package .api contains one interface CRUDResource that is not used anywhere. Can we remove it?
  • Class SpMediaType
    • Contains the type JSONLD, can we remove this? It is only used in one API and I guess that is legacy code that we do not need anymore.
    • Then this class will only contain one variable APPLICATION_ZIP that is used. Can we move this to remove the class?

In general this seems to be a rather small module. Can we move the packages to somewhere else or should we wait till we start refactor the REST API modules?

StreamPipes Committer

I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.

tenthe avatar Jan 05 '23 08:01 tenthe

@dominikriemer what is your opinion on this issue?

tenthe avatar Jan 05 '23 08:01 tenthe

The unused interface, CRUDResource and JSONLD media type can be removed from my point of view!

dominikriemer avatar Jan 05 '23 22:01 dominikriemer