storm icon indicating copy to clipboard operation
storm copied to clipboard

Storm-Pulsar bolt and spout

Open dlg99 opened this issue 3 years ago • 2 comments

What is the purpose of the change

Apache Pulsar is a popular streaming and messaging platform. It provides storm integration as part of the pulsar-adapters subproject but the storm adapter never keeps up with the latest storm changes/builds. The adapter does not require much knowledge about the pulsar internals but knowledge of Storm internals is something that is more beneficial. This PR is an attempt to transition pulsar-storm adapter to the storm community .

How was the change tested

Unit/integration test.

dlg99 avatar Feb 09 '22 00:02 dlg99

Travis build is failing for unrelated reasons. I built and tested as:

mvn clean install -DskipTests -P '!examples,!externals'
cd external/storm-pulsar/
mvn clean install
...
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.pulsar.storm.PulsarSpoutIntegrationTest
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 71.711 s - in org.apache.pulsar.storm.PulsarSpoutIntegrationTest
[INFO] Running org.apache.pulsar.storm.PulsarSpoutTest
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.098 s - in org.apache.pulsar.storm.PulsarSpoutTest
[INFO] Running org.apache.pulsar.storm.PulsarBoltIntegrationTest
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 42.811 s - in org.apache.pulsar.storm.PulsarBoltIntegrationTest
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 22, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------

dlg99 avatar Feb 09 '22 01:02 dlg99

Travis needs https://github.com/apache/storm/pull/3437 ...

rzo1 avatar Feb 09 '22 06:02 rzo1

Overall looks good to me. Thanks @dlg99 for the great job. And do you have any updates for @agresch and @bipinprasad comments?

vesense avatar Mar 03 '23 02:03 vesense