storm icon indicating copy to clipboard operation
storm copied to clipboard

[STORM-3132] Avoid NPE in the Values Constructor

Open kishorvpatil opened this issue 7 years ago • 4 comments

Values construction could end up throwing NPE.

kishorvpatil avatar Jun 29 '18 06:06 kishorvpatil

So this changes a Values(null) into a Values() That is not really what I would expect. I would prefer to have Values(null) insert a null into the list. Values(null, "A") does not turn into Values("A").

revans2 avatar Jun 29 '18 15:06 revans2

+1 to @revans2.

HeartSaVioR avatar Jul 03 '18 07:07 HeartSaVioR

@revans2 @HeartSaVioR Now constructor allows null values.

kishorvpatil avatar Jul 09 '18 21:07 kishorvpatil

@HeartSaVioR Removed unwanted condition.

kishorvpatil avatar Jul 13 '18 15:07 kishorvpatil