spark icon indicating copy to clipboard operation
spark copied to clipboard
verified publisher icon apache

[SPARK-54442][SQL][FOLLOWUP] Add codegen for TIME numeric conversion functions

Open vinodkc opened this issue 3 weeks ago • 1 comments

What changes were proposed in this pull request?

Implemented whole-stage codegen for TIME conversion functions (IntegralToTimeBase, TimeFromSeconds, TimeToSeconds) by removing CodegenFallback

Why are the changes needed?

Performance: CodegenFallback is 10-50x slower than generated code Pattern consistency: Follows existing Spark patterns (IntegralToTimestampBase)

Does this PR introduce any user-facing change?

No. performance optimization with identical results.

How was this patch tested?

All existing tests pass Generated code inspection confirms optimizations

Was this patch authored or co-authored using generative AI tooling?

No

vinodkc avatar Dec 07 '25 04:12 vinodkc

cc @cloud-fan

HyukjinKwon avatar Dec 07 '25 22:12 HyukjinKwon

thanks, merging to master!

cloud-fan avatar Dec 15 '25 02:12 cloud-fan