apache
[SPARK-52475][TESTS] Remove deprecated table.schema method from tests
What changes were proposed in this pull request?
Fix many compile warnings like
[warn] /Users/szehon.ho/repos/apache-spark/spark/sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/CatalogSuite.scala:282:18: method schema in trait Table is deprecated (since 3.4.0)
[warn] Applicable -Wconf / @nowarn filters for this warning: msg=<part of the message>, cat=deprecation, site=org.apache.spark.sql.connector.catalog.CatalogSuite, origin=org.apache.spark.sql.connector.catalog.Table.schema, version=3.4.0
Why are the changes needed?
Reduce compiler warnings
Does this PR introduce any user-facing change?
No
How was this patch tested?
Test only
Was this patch authored or co-authored using generative AI tooling?
No
Here are a huge number of compilation warnings related to "method schema in trait Table is deprecated". Can we fix them all at once? Or, could we resolve all of them in tests in one go? Fixing them one by one would lead to a multitude of prs.
Yea its a large number and a bit time consuming, so I was thinking to at least make progress and avoid conflict risk by reasonable size batches. Let me look at removing from all the tests
@szehon-ho Thank you for your work. However, it seems there are some compilation errors that need to be fixed first.
sql-others has test failures:
- org.apache.spark.sql.execution.datasources.v2.V2SessionCatalogTableSuite
In addition,
./build/mvn scalafmt:format -Dscalafmt.skip=false -Dscalafmt.validateOnly=false -Dscalafmt.changedOnly=false -pl sql/api -pl sql/connect/common -pl sql/connect/server -pl sql/connect/client/jvm
should be executed. @szehon-ho
Sorry there's a lot of tests and I missed running some locally first, thanks for your help
