spark icon indicating copy to clipboard operation
spark copied to clipboard

Update supported_api_gen.py: remove an invalid escape sequence "\_" using a raw string

Open wyattscarpenter opened this issue 9 months ago • 4 comments

What changes were proposed in this pull request?

Remove an invalid escape sequence "_" using a raw string instead.

Why are the changes needed?

There is an invalid escape sequence in the code, which is silenced using a noqa comment. Recent python versions warn when parsing such a string, noqa comment or no. (I believe I may have seen this warning when mypy, a python typechecker, visited the code, or something like that.) Using a raw string removes the warning without changing the value of the string in this case. This change also allows us to remove a noqa comment.

Does this PR introduce any user-facing change?

No, except a python warning is silenced.

How was this patch tested?

Manual inspection.

Was this patch authored or co-authored using generative AI tooling?

No.

wyattscarpenter avatar Mar 11 '25 23:03 wyattscarpenter

Mind filling the PR description please? https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE

HyukjinKwon avatar Mar 17 '25 00:03 HyukjinKwon

@HyukjinKwon Sure! Sorry for the delay.

wyattscarpenter avatar May 07 '25 07:05 wyattscarpenter

Also we might need a JIRA ticket for the PR proposal. Please JIRA section of https://spark.apache.org/contributing.html

xinrong-meng avatar May 13 '25 18:05 xinrong-meng

Thanks for mentioning!

Reviewing that document, I take this sentence to indicate that this doesn't need a JIRA ticket:

If the change is new, then it usually needs a new JIRA. However, trivial changes, where the what should change is virtually the same as the how it should change do not require a JIRA. Example: Fix typos in Foo scaladoc

wyattscarpenter avatar May 14 '25 01:05 wyattscarpenter

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

github-actions[bot] avatar Aug 23 '25 00:08 github-actions[bot]

This PR is still good and necessary. To whomever is concerned: it should not be marked stale.

wyattscarpenter avatar Aug 23 '25 00:08 wyattscarpenter