spark icon indicating copy to clipboard operation
spark copied to clipboard

[MINOR][INFRA] Do not upload docker build record

Open EnricoMi opened this issue 1 year ago • 3 comments

What changes were proposed in this pull request?

Make docker/build-push-action action not upload the docker build record.

Why are the changes needed?

The way docker/build-push-action uploads the file breaks action dawidd6/action-download-artifact, which breaks the test_report.yaml workflow that publishes test results.

==> Downloading: G-Research~spark~R7TXVG.dockerbuild.zip (23.76 kB)
Error: Invalid or unsupported zip format. No END header found

https://github.com/G-Research/spark/actions/runs/10733657395/job/29767392437#step:2:27-27

See https://github.com/docker/build-push-action/issues/1167.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Tested in GitHub CI.

Was this patch authored or co-authored using generative AI tooling?

No.

EnricoMi avatar Sep 06 '24 07:09 EnricoMi

cc @Yikun FYI

HyukjinKwon avatar Sep 06 '24 07:09 HyukjinKwon

Here is a run with #48011 only: https://github.com/G-Research/spark/actions/runs/10734782837/job/29770679477

Here is a run with #48011 and this fix applied: https://github.com/G-Research/spark/actions/runs/10734871365/job/29770953865

EnricoMi avatar Sep 06 '24 08:09 EnricoMi

Current spark job doesn't depends on docker build record, so it's safe.

Any other steps should be also be changed? If not, LGTM.

Yikun avatar Oct 18 '24 04:10 Yikun

@Yikun moved the env from step to workflow level so it applies to all steps

EnricoMi avatar Jan 16 '25 14:01 EnricoMi

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

github-actions[bot] avatar Aug 07 '25 00:08 github-actions[bot]