spark icon indicating copy to clipboard operation
spark copied to clipboard

[SPARK-49210][SQL] Support driver metrics for DS v2 write

Open Zouxxyy opened this issue 1 year ago • 1 comments

What changes were proposed in this pull request?

Support driver metrics for DS v2 write

Why are the changes needed?

For v2 tables like iceberg or paimon, its write metrics are very useful, by supporting driver metrics, we can report commit time, commited files, snapshot id etc.

Does this PR introduce any user-facing change?

Extract common interface SupportCustomMetrics for write and scan

How was this patch tested?

Add test case for writing v2 and v1 fallback table

Was this patch authored or co-authored using generative AI tooling?

No

Zouxxyy avatar Aug 12 '24 10:08 Zouxxyy

@cloud-fan @viirya @dongjoon-hyun Can you help with the review? Thanks

Zouxxyy avatar Aug 13 '24 01:08 Zouxxyy

Sorry I missed this. https://github.com/apache/spark/pull/48573 did the same thing, and I think it's simpler to have separate APIs for Scan and Write, instead of adding a common interface for it.

cloud-fan avatar Nov 20 '24 04:11 cloud-fan