spark icon indicating copy to clipboard operation
spark copied to clipboard

Published 20 hours ago • verified publisher icon apache

[SPARK-48209][CORE] Common (java side): Migrate `error/warn/info` with variables to structured logging framework

Open panbingkun opened this issue 1 year ago • 3 comments
trafficstars

What changes were proposed in this pull request?

The pr aims to 1.migrate error/warn/info in module common with variables to structured logging framework for java side. 2.convert all dependencies on org.slf4j.Logger & org.slf4j.LoggerFactory to org.apache.spark.internal.Logger & org.apache.spark.internal.LoggerFactory, in order to completely prohibit importing org.slf4j.Logger & org.slf4j.LoggerFactory in java code later.

Why are the changes needed?

To enhance Apache Spark's logging system by implementing structured logging.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

  • Pass GA.

Was this patch authored or co-authored using generative AI tooling?

No.

panbingkun avatar May 09 '24 02:05 panbingkun

cc @gengliangwang

panbingkun avatar May 10 '24 03:05 panbingkun

LGTM overall. Thanks for the work!

gengliangwang avatar May 10 '24 22:05 gengliangwang

LGTM overall. Thanks for the work!

Updated, thanks! ❤️

panbingkun avatar May 10 '24 23:05 panbingkun

Thanks, merging to master

gengliangwang avatar May 14 '24 04:05 gengliangwang