spark icon indicating copy to clipboard operation
spark copied to clipboard
verified publisher icon apache

[SPARK-46876]csv line containing delimiter can't be treated as empty line

Open doki23 opened this issue 1 year ago • 2 comments

What changes were proposed in this pull request?

Don't treat csv line which only containing delimiters as an empty line in case of being filtered.

Why are the changes needed?

SPARK-46876

Does this PR introduce any user-facing change?

No

How was this patch tested?

Not yet, WIP

Was this patch authored or co-authored using generative AI tooling?

No.

doki23 avatar Jan 30 '24 06:01 doki23

Some unit-test that will prevent regression would be nice :)

Thanks for fixing this!

martinitus avatar Jan 30 '24 11:01 martinitus

It's ready for review.

doki23 avatar Feb 01 '24 09:02 doki23

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

github-actions[bot] avatar Jun 01 '24 00:06 github-actions[bot]