spark
spark copied to clipboard
[SPARK-36853][BUILD] Code failing on checkstyle
What changes were proposed in this pull request?
Fixed the checkstyle error thrown in windows in maven installing phase.
Why are the changes needed?
Due to some problems in CI system, these obvious errors have not been detected. I think these checkstyle errors should be solved.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
I have verified by executing following commands in the win10 system, except for (modifier) RedundantModifier in TimSort.java and (naming) MethodName in GroupStateTimeout.java and OutputMode.java and Trigger.java, the rest of the errors have been fixed.
mvn -DskipTest clean install
@srowen Sorry, the previous PR has been inconvenient to modify because it took too long, so the code has been migrated to this PR.
@Shockang the test in the GitHub Actions fails because your fork is based on the old master branch. do you mind rebasing it to sync to the latest master
branch?
ok to test
@Shockang the test in the GitHub Actions fails because your fork is based on the old master branch. do you mind rebasing it to sync to the latest
master
branch?
Of course not. I will merge the latest master code.
Can one of the admins verify this patch?
Ping @Shockang - see comments
Ping @Shockang