spark icon indicating copy to clipboard operation
spark copied to clipboard

[SPARK-36853][BUILD] Code failing on checkstyle

Open Shockang opened this issue 3 years ago • 7 comments

What changes were proposed in this pull request?

Fixed the checkstyle error thrown in windows in maven installing phase.

Why are the changes needed?

Due to some problems in CI system, these obvious errors have not been detected. I think these checkstyle errors should be solved.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

I have verified by executing following commands in the win10 system, except for (modifier) RedundantModifier in TimSort.java and (naming) MethodName in GroupStateTimeout.java and OutputMode.java and Trigger.java, the rest of the errors have been fixed. mvn -DskipTest clean install

Shockang avatar Dec 25 '21 06:12 Shockang

@srowen Sorry, the previous PR has been inconvenient to modify because it took too long, so the code has been migrated to this PR.

Shockang avatar Dec 25 '21 06:12 Shockang

@Shockang the test in the GitHub Actions fails because your fork is based on the old master branch. do you mind rebasing it to sync to the latest master branch?

HyukjinKwon avatar Dec 26 '21 03:12 HyukjinKwon

ok to test

HyukjinKwon avatar Dec 26 '21 03:12 HyukjinKwon

@Shockang the test in the GitHub Actions fails because your fork is based on the old master branch. do you mind rebasing it to sync to the latest master branch?

Of course not. I will merge the latest master code.

Shockang avatar Dec 26 '21 09:12 Shockang

Can one of the admins verify this patch?

AmplabJenkins avatar Dec 26 '21 20:12 AmplabJenkins

Ping @Shockang - see comments

srowen avatar Mar 24 '22 16:03 srowen

Ping @Shockang

srowen avatar Aug 31 '22 18:08 srowen