solr icon indicating copy to clipboard operation
solr copied to clipboard

SOLR-11033: introduce multilingual configset

Open epugh opened this issue 3 years ago • 12 comments

https://issues.apache.org/jira/browse/SOLR-11033

Description

See JIRA

Solution

Please provide a short description of the approach taken to implement your solution.

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

  • [ ] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • [ ] I have created a Jira issue and added the issue ID to my pull request title.
  • [ ] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • [ ] I have developed this patch against the main branch.
  • [ ] I have run ./gradlew check.
  • [ ] I have added tests for my changes.
  • [ ] I have added documentation for the Reference Guide

epugh avatar Aug 10 '22 14:08 epugh

The code for loading the _multilingual configset is rough, and probably can be refactored. However it all appears to work!

epugh avatar Aug 15 '22 21:08 epugh

Hi Eric, will go through this soon!

thelabdude avatar Aug 15 '22 23:08 thelabdude

TestSchemaDesignerConfigSetHelper.testEnableDisableOptions is busted... TestSchemaAPI all works.....

epugh avatar Aug 16 '22 14:08 epugh

Also, feel free to push any changes to this branch ;-)

epugh avatar Aug 16 '22 17:08 epugh

what's the timing for this? I see the jira was opened years ago, why is this needed now anyway?

I'll need some time (that I don't have right now) to think through all of this ...

thelabdude avatar Aug 16 '22 18:08 thelabdude

It actually isn't time sensitive... Though I hope it doesn't linger on the vine for weeks ;-). It would be nice to have it in before a 9.1 release. If this goes through, imagine if we added more sample collections like a _geospatial or _embeddings or even _onnx that users can adopt via the Schema Designer ;-).

epugh avatar Aug 16 '22 18:08 epugh

Tests are now passing, though I don't love what I did in #7354bb629318a59ab51d80332f4cdf355d590cd7 to make it pass!

epugh avatar Aug 17 '22 14:08 epugh

@thelabdude I just heard the very first rumbling of a 9.1 release.... Have you had a chance to think more about this approach? Does this need a discussion on the mailing list?

epugh avatar Sep 14 '22 12:09 epugh

This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the [email protected] mailing list. Thank you for your contribution!

github-actions[bot] avatar Feb 19 '24 00:02 github-actions[bot]