solr icon indicating copy to clipboard operation
solr copied to clipboard

SOLR-16260: Add support for Instant, LocalDate and ZonedDateTime to JavaBinCodec

Open sgift opened this issue 3 years ago • 1 comments

https://issues.apache.org/jira/browse/SOLR-16260

Description

Adds support for Instant, LocalDate and ZonedDateTime to JavaBinCodec.

Solution

Instant, LocalDate and ZonedDateTime are converted to epoch millis and stored as type DATE in the serialized bytes.

Tests

I've added a test to TestJavaBinCodec, which tests that all three classes can be serialized and deserialized and return a Date with the same time as the input.

Checklist

Please review the following and check all that apply:

  • [x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • [x] I have created a Jira issue and added the issue ID to my pull request title.
  • [x] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • [x] I have developed this patch against the main branch.
  • [x] I have run ./gradlew check.
  • [x] I have added tests for my changes.
  • [ ] I have added documentation for the Reference Guide

sgift avatar Jun 22 '22 14:06 sgift

@sgift this looks clean and simple! Thanks for the contribution 🙂

HoustonPutman avatar Jun 23 '22 15:06 HoustonPutman

This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the [email protected] mailing list. Thank you for your contribution!

github-actions[bot] avatar Feb 20 '24 00:02 github-actions[bot]