solr icon indicating copy to clipboard operation
solr copied to clipboard

Attempt to fix various testing thread leaks

Open HoustonPutman opened this issue 3 years ago • 1 comments

Will create a JIRA if people think it's worth it.

HoustonPutman avatar Mar 30 '22 16:03 HoustonPutman

The failing tests are threads leaking in TestCancellableCollector and OrderedExecutorTest.

I can't reproduce the failures locally, but it seems like a harmless addition to try and kill the threads after the tests finish. The threads aren't solr threads, merely test threads, so it shouldn't be a big deal to kill them immediately on close.

But I'll wait on this until Mike has done his work on his branch.

HoustonPutman avatar Mar 30 '22 17:03 HoustonPutman

Closing this as there was better work done to fix these.

HoustonPutman avatar Aug 18 '22 03:08 HoustonPutman