solr icon indicating copy to clipboard operation
solr copied to clipboard

Added support in solrj client to add query fields/params through java 8 consumer

Open venkatrockz opened this issue 4 years ago • 2 comments

https://issues.apache.org/jira/browse/SOLR-XXXXX

Description

Added support in solrj client to add query fields/params through java 8 consumer. I have added new method in solr query class which will take solr query consumer as parameter and return the solr query in order to make it easy for chaining.

Solution

Please provide a short description of the approach taken to implement your solution.

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

  • [ ] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • [ ] I have created a Jira issue and added the issue ID to my pull request title.
  • [ ] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • [ ] I have developed this patch against the main branch.
  • [ ] I have run ./gradlew check.
  • [ ] I have added tests for my changes.
  • [ ] I have added documentation for the Reference Guide

venkatrockz avatar Dec 21 '21 02:12 venkatrockz

Please create a JIRA and fill in the PR template. Also, you have to explain the feature you are proposing much more in detail. Give examples of what is difficult to achieve today, then explain what a Consumer is and how to use it and why you think it justifies expanding the API. Then there may be some discussion in JIRA or here in the PR.

If there is agreement that this is useful, you'd need to also add CHANGES.txt entry and Reference Guide documentation (if applicable)

janhoy avatar Jan 17 '22 12:01 janhoy

Any followup on this?

janhoy avatar Mar 10 '22 19:03 janhoy